Hi

On Tue, May 18, 2021 at 04:49:45PM +0200, Geert Uytterhoeven wrote:
> On Tue, May 18, 2021 at 4:33 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > On Tue, May 18, 2021 at 09:51:31AM +0200, Geert Uytterhoeven wrote:
> > > Convert the Solomon SSD1307 Framebuffer Device Tree binding
> > > documentation to json-schema.
> > >
> > > Fix the spelling of the "pwms" property.
> > > Document default values.
> > > Make properties with default values not required.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > ---
> > > I have listed Maxime as the maintainer, as he wrote the original driver
> > > and bindings.  Maxime: Please scream if this is inappropriate ;-)
> >
> > Fine by me :)
> 
> Thanks!
> 
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> 
> > > +  solomon,dclk-div:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    minimum: 1
> > > +    maximum: 16
> > > +    description:
> > > +      Clock divisor. The default value is controller-dependent.
> >
> > I guess we could document the default using an if / else statement?
> 
> While clk-div has only two different defaults, dclk-frq has different
> defaults for each of the 4 variants supported.
> 
> Do you think it's worthwhile doing that? All upstream DTS files lack
> these properties, thus use the default values.

I'd say it's even more important if everyone relies on it :)

Maxime