linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	linux-fbdev@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] backlight: lm3630a: fix return code of .update_status() callback
Date: Mon, 21 Jun 2021 12:41:53 +0100	[thread overview]
Message-ID: <20210621114153.jg5hll46xj2unin5@maple.lan> (raw)
In-Reply-To: <20210621102351.45m2oznsmg5nfv6t@maple.lan>

On Mon, Jun 21, 2021 at 11:23:51AM +0100, Daniel Thompson wrote:
> On Sun, Jun 20, 2021 at 09:39:27PM +0200, Uwe Kleine-König wrote:
> > According to <linux/backlight.h> .update_status() is supposed to
> > return 0 on success and a negative error code otherwise. Adapt
> > lm3630a_bank_a_update_status() to actually do it.
> > 
> > While touching that also add the error code to the failure message.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Thanks for this!
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Sorry... looks like I was a little hasty here.

As mentioned in https://marc.info/?l=linux-fbdev&m=162427245024751&w=2
when lm3630a_bank_b_update_status() needs similar fixes.

Just wanted to put something in the ML record so Lee doesn't pick this
patch based on my R-b above...


Danieo.


> 
> 
> Daniel.
> 
> 
> > ---
> >  drivers/video/backlight/lm3630a_bl.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> > index e88a2b0e5904..16a2658a72e1 100644
> > --- a/drivers/video/backlight/lm3630a_bl.c
> > +++ b/drivers/video/backlight/lm3630a_bl.c
> > @@ -190,7 +190,7 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
> >  	if ((pwm_ctrl & LM3630A_PWM_BANK_A) != 0) {
> >  		lm3630a_pwm_ctrl(pchip, bl->props.brightness,
> >  				 bl->props.max_brightness);
> > -		return bl->props.brightness;
> > +		return 0;
> >  	}
> >  
> >  	/* disable sleep */
> > @@ -210,8 +210,8 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
> >  	return 0;
> >  
> >  out_i2c_err:
> > -	dev_err(pchip->dev, "i2c failed to access\n");
> > -	return bl->props.brightness;
> > +	dev_err(pchip->dev, "i2c failed to access (%pe)\n", ERR_PTR(ret));
> > +	return ret;
> >  }
> >  
> >  static int lm3630a_bank_a_get_brightness(struct backlight_device *bl)
> > 
> > base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
> > -- 
> > 2.30.2
> > 

      reply	other threads:[~2021-06-21 11:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 19:39 Uwe Kleine-König
2021-06-20 19:39 ` [PATCH v2 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors Uwe Kleine-König
2021-06-21 10:47   ` Daniel Thompson
2021-06-21 10:23 ` [PATCH v2 1/2] backlight: lm3630a: fix return code of .update_status() callback Daniel Thompson
2021-06-21 11:41   ` Daniel Thompson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621114153.jg5hll46xj2unin5@maple.lan \
    --to=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --subject='Re: [PATCH v2 1/2] backlight: lm3630a: fix return code of .update_status() callback' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).