From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: gustavoars@kernel.org, sam@ravnborg.org, tomi.valkeinen@ti.com,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] OMAP: DSS2: OMAPFB: fix potential GPF
Date: Sun, 27 Jun 2021 02:14:23 +0300 [thread overview]
Message-ID: <20210626231423.GA38365@macbook.musicnaut.iki.fi> (raw)
In-Reply-To: <20210625223323.13930-1-paskripkin@gmail.com>
Hi,
On Sat, Jun 26, 2021 at 01:33:23AM +0300, Pavel Skripkin wrote:
> In case of allocation failures, all code paths was jumping
> to this code:
>
> err:
> kfree(fbi);
> kfree(var);
> kfree(fbops);
>
> return r;
>
> Since all 3 pointers placed on stack and don't initialized, they
> will be filled with some random values, which leads to
> deferencing random pointers in kfree(). Fix it by rewriting
> error handling path.
They are initialized before the first goto:
[...]
fbi = NULL;
var = NULL;
fbops = NULL;
fbi = kzalloc(sizeof(*fbi), GFP_KERNEL);
if (fbi == NULL) {
r = -ENOMEM;
goto err;
}
[...]
A.
next prev parent reply other threads:[~2021-06-26 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 22:33 [PATCH] OMAP: DSS2: OMAPFB: fix potential GPF Pavel Skripkin
2021-06-26 23:14 ` Aaro Koskinen [this message]
2021-06-27 8:48 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210626231423.GA38365@macbook.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=sam@ravnborg.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).