linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero
@ 2021-07-13 19:16 Marek Vasut
  2021-09-11 18:40 ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2021-07-13 19:16 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-fbdev, Marek Vasut, Noralf Trønnes, Daniel Thompson,
	stable, Meghana Madhyastha, Sean Paul, Thierry Reding

The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper
in backlight.c") says that gpio-backlight uses brightness as power state.
This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
Correct initial power state handling") and other backlight drivers do not
require this workaround. Drop the workaround.

This fixes the case where e.g. pwm-backlight can perfectly well be set to
brightness 0 on boot in DT, which without this patch leads to the display
brightness to be max instead of off.

Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c")
Acked-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: <stable@vger.kernel.org> # 5.4+
Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Thierry Reding <treding@nvidia.com>
---
V2: Add AB/RB, CC stable
---
 drivers/video/backlight/backlight.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 537fe1b376ad7..fc990e576340b 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
 			of_node_put(np);
 			if (!bd)
 				return ERR_PTR(-EPROBE_DEFER);
-			/*
-			 * Note: gpio_backlight uses brightness as
-			 * power state during probe
-			 */
-			if (!bd->props.brightness)
-				bd->props.brightness = bd->props.max_brightness;
 		}
 	}
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero
  2021-07-13 19:16 [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero Marek Vasut
@ 2021-09-11 18:40 ` Marek Vasut
  2021-09-21 13:33   ` Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2021-09-11 18:40 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-fbdev, Noralf Trønnes, Daniel Thompson, stable,
	Meghana Madhyastha, Sean Paul, Thierry Reding, Sam Ravnborg,
	Lee Jones

On 7/13/21 9:16 PM, Marek Vasut wrote:
> The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper
> in backlight.c") says that gpio-backlight uses brightness as power state.
> This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
> Correct initial power state handling") and other backlight drivers do not
> require this workaround. Drop the workaround.
> 
> This fixes the case where e.g. pwm-backlight can perfectly well be set to
> brightness 0 on boot in DT, which without this patch leads to the display
> brightness to be max instead of off.
> 
> Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c")
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: <stable@vger.kernel.org> # 5.4+
> Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Thierry Reding <treding@nvidia.com>
> ---
> V2: Add AB/RB, CC stable
> ---
>   drivers/video/backlight/backlight.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> index 537fe1b376ad7..fc990e576340b 100644
> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
> @@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
>   			of_node_put(np);
>   			if (!bd)
>   				return ERR_PTR(-EPROBE_DEFER);
> -			/*
> -			 * Note: gpio_backlight uses brightness as
> -			 * power state during probe
> -			 */
> -			if (!bd->props.brightness)
> -				bd->props.brightness = bd->props.max_brightness;
>   		}
>   	}
>   
> 

Any news on this ?

Expanding CC list.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero
  2021-09-11 18:40 ` Marek Vasut
@ 2021-09-21 13:33   ` Lee Jones
  2021-09-21 17:31     ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2021-09-21 13:33 UTC (permalink / raw)
  To: Marek Vasut
  Cc: dri-devel, linux-fbdev, Noralf Trønnes, Daniel Thompson,
	stable, Meghana Madhyastha, Sean Paul, Thierry Reding,
	Sam Ravnborg

On Sat, 11 Sep 2021, Marek Vasut wrote:

> On 7/13/21 9:16 PM, Marek Vasut wrote:
> > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper
> > in backlight.c") says that gpio-backlight uses brightness as power state.
> > This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
> > Correct initial power state handling") and other backlight drivers do not
> > require this workaround. Drop the workaround.
> > 
> > This fixes the case where e.g. pwm-backlight can perfectly well be set to
> > brightness 0 on boot in DT, which without this patch leads to the display
> > brightness to be max instead of off.
> > 
> > Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c")
> > Acked-by: Noralf Trønnes <noralf@tronnes.org>
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: <stable@vger.kernel.org> # 5.4+
> > Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> > Cc: Noralf Trønnes <noralf@tronnes.org>
> > Cc: Sean Paul <seanpaul@chromium.org>
> > Cc: Thierry Reding <treding@nvidia.com>
> > ---
> > V2: Add AB/RB, CC stable
> > ---
> >   drivers/video/backlight/backlight.c | 6 ------
> >   1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> > index 537fe1b376ad7..fc990e576340b 100644
> > --- a/drivers/video/backlight/backlight.c
> > +++ b/drivers/video/backlight/backlight.c
> > @@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
> >   			of_node_put(np);
> >   			if (!bd)
> >   				return ERR_PTR(-EPROBE_DEFER);
> > -			/*
> > -			 * Note: gpio_backlight uses brightness as
> > -			 * power state during probe
> > -			 */
> > -			if (!bd->props.brightness)
> > -				bd->props.brightness = bd->props.max_brightness;
> >   		}
> >   	}
> > 
> 
> Any news on this ?
> 
> Expanding CC list.

Looks like I was left off of the original submission.

I can't apply a quoted patch.  Please re-submit.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero
  2021-09-21 13:33   ` Lee Jones
@ 2021-09-21 17:31     ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2021-09-21 17:31 UTC (permalink / raw)
  To: Lee Jones
  Cc: dri-devel, linux-fbdev, Noralf Trønnes, Daniel Thompson,
	stable, Meghana Madhyastha, Sean Paul, Thierry Reding,
	Sam Ravnborg

On 9/21/21 3:33 PM, Lee Jones wrote:
> On Sat, 11 Sep 2021, Marek Vasut wrote:
> 
>> On 7/13/21 9:16 PM, Marek Vasut wrote:
>>> The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper
>>> in backlight.c") says that gpio-backlight uses brightness as power state.
>>> This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
>>> Correct initial power state handling") and other backlight drivers do not
>>> require this workaround. Drop the workaround.
>>>
>>> This fixes the case where e.g. pwm-backlight can perfectly well be set to
>>> brightness 0 on boot in DT, which without this patch leads to the display
>>> brightness to be max instead of off.
>>>
>>> Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c")
>>> Acked-by: Noralf Trønnes <noralf@tronnes.org>
>>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>>> Cc: <stable@vger.kernel.org> # 5.4+
>>> Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Daniel Thompson <daniel.thompson@linaro.org>
>>> Cc: Meghana Madhyastha <meghana.madhyastha@gmail.com>
>>> Cc: Noralf Trønnes <noralf@tronnes.org>
>>> Cc: Sean Paul <seanpaul@chromium.org>
>>> Cc: Thierry Reding <treding@nvidia.com>
>>> ---
>>> V2: Add AB/RB, CC stable
>>> ---
>>>    drivers/video/backlight/backlight.c | 6 ------
>>>    1 file changed, 6 deletions(-)
>>>
>>> diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
>>> index 537fe1b376ad7..fc990e576340b 100644
>>> --- a/drivers/video/backlight/backlight.c
>>> +++ b/drivers/video/backlight/backlight.c
>>> @@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
>>>    			of_node_put(np);
>>>    			if (!bd)
>>>    				return ERR_PTR(-EPROBE_DEFER);
>>> -			/*
>>> -			 * Note: gpio_backlight uses brightness as
>>> -			 * power state during probe
>>> -			 */
>>> -			if (!bd->props.brightness)
>>> -				bd->props.brightness = bd->props.max_brightness;
>>>    		}
>>>    	}
>>>
>>
>> Any news on this ?
>>
>> Expanding CC list.
> 
> Looks like I was left off of the original submission.
> 
> I can't apply a quoted patch.  Please re-submit.

I see. It seems the patch is available in both Lore and Patchwork:

https://lore.kernel.org/all/072e01b7-8554-de4f-046a-da11af3958d6@denx.de/T/

https://patchwork.freedesktop.org/patch/443823/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-21 17:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 19:16 [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero Marek Vasut
2021-09-11 18:40 ` Marek Vasut
2021-09-21 13:33   ` Lee Jones
2021-09-21 17:31     ` Marek Vasut

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox