From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42E4C64E7C for ; Sat, 21 Nov 2020 17:10:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C2A72224A for ; Sat, 21 Nov 2020 17:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbgKURKS (ORCPT ); Sat, 21 Nov 2020 12:10:18 -0500 Received: from smtprelay0130.hostedemail.com ([216.40.44.130]:44438 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726281AbgKURKR (ORCPT ); Sat, 21 Nov 2020 12:10:17 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id C09E2837F24A; Sat, 21 Nov 2020 17:10:14 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: crook72_110ffeb27355 X-Filterd-Recvd-Size: 4090 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Sat, 21 Nov 2020 17:10:09 +0000 (UTC) Message-ID: <2105f0c05e9eae8bee8e17dcc5314474b3c0bc73.camel@perches.com> Subject: Re: [RFC] MAINTAINERS tag for cleanup robot From: Joe Perches To: trix@redhat.com, clang-built-linux@googlegroups.com Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, tboot-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, keyrings@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, alsa-devel@alsa-project.org, bpf@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-nfs@vger.kernel.org, patches@opensource.cirrus.com Date: Sat, 21 Nov 2020 09:10:08 -0800 In-Reply-To: <20201121165058.1644182-1-trix@redhat.com> References: <20201121165058.1644182-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Sat, 2020-11-21 at 08:50 -0800, trix@redhat.com wrote: > A difficult part of automating commits is composing the subsystem > preamble in the commit log. For the ongoing effort of a fixer producing > one or two fixes a release the use of 'treewide:' does not seem appropriate. > > It would be better if the normal prefix was used. Unfortunately normal is > not consistent across the tree. > > So I am looking for comments for adding a new tag to the MAINTAINERS file > > D: Commit subsystem prefix > > ex/ for FPGA DFL DRIVERS > > D: fpga: dfl: I'm all for it. Good luck with the effort. It's not completely trivial. >From a decade ago: https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/ (and that thread started with extra semicolon patches too) > Continuing with cleaning up clang's -Wextra-semi-stmt > diff --git a/Makefile b/Makefile [] > @@ -1567,20 +1567,21 @@ help: >   echo '' >   @echo 'Static analysers:' >   @echo ' checkstack - Generate a list of stack hogs' >   @echo ' versioncheck - Sanity check on version.h usage' >   @echo ' includecheck - Check for duplicate included header files' >   @echo ' export_report - List the usages of all exported symbols' >   @echo ' headerdep - Detect inclusion cycles in headers' >   @echo ' coccicheck - Check with Coccinelle' >   @echo ' clang-analyzer - Check with clang static analyzer' >   @echo ' clang-tidy - Check with clang-tidy' > + @echo ' clang-tidy-fix - Check and fix with clang-tidy' A pity the ordering of the code below isn't the same as the above. > -PHONY += clang-tidy clang-analyzer > +PHONY += clang-tidy-fix clang-tidy clang-analyzer [] > -clang-tidy clang-analyzer: $(extmod-prefix)compile_commands.json > +clang-tidy-fix clang-tidy clang-analyzer: $(extmod-prefix)compile_commands.json >   $(call cmd,clang_tools) >  else > -clang-tidy clang-analyzer: > +clang-tidy-fix clang-tidy clang-analyzer: [] > diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py [] > @@ -22,43 +22,57 @@ def parse_arguments(): [] >      parser.add_argument("type", > - choices=["clang-tidy", "clang-analyzer"], > + choices=["clang-tidy-fix", "clang-tidy", "clang-analyzer"], etc...