From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD2CC64E8A for ; Mon, 30 Nov 2020 13:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05746206F9 for ; Mon, 30 Nov 2020 13:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726041AbgK3NXM (ORCPT ); Mon, 30 Nov 2020 08:23:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:57366 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgK3NXM (ORCPT ); Mon, 30 Nov 2020 08:23:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0143BAC91; Mon, 30 Nov 2020 13:22:30 +0000 (UTC) Subject: Re: [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-19-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <21d7f316-120d-930a-98c1-27426f6439cc@suse.de> Date: Mon, 30 Nov 2020 14:22:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-19-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W5ondu2BzooQuN1TJhHShX5xd8qVp4c8s" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W5ondu2BzooQuN1TJhHShX5xd8qVp4c8s Content-Type: multipart/mixed; boundary="gBhdQZ4fzKcCFXCbfYJKRXkfI9yrNiC2e"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan Message-ID: <21d7f316-120d-930a-98c1-27426f6439cc@suse.de> Subject: Re: [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-19-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-19-sam@ravnborg.org> --gBhdQZ4fzKcCFXCbfYJKRXkfI9yrNiC2e Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > Fix W=3D1 warnings: > - Fix kernel-doc > - Drop unused code/variables > - Use memcpy to copy a string without zero-termination > strncpy() generates a warning >=20 > v2: > - Updated subject (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Cc: Daniel Vetter > Cc: Xiaofei Tan > Cc: Arnd Bergmann > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/mx3fb.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c > index 894617ddabcb..fabb271337ed 100644 > --- a/drivers/video/fbdev/mx3fb.c > +++ b/drivers/video/fbdev/mx3fb.c > @@ -445,7 +445,6 @@ static void sdc_enable_channel(struct mx3fb_info *m= x3_fbi) > static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) > { > struct mx3fb_data *mx3fb =3D mx3_fbi->mx3fb; > - uint32_t enabled; > unsigned long flags; > =20 > if (mx3_fbi->txd =3D=3D NULL) > @@ -453,7 +452,7 @@ static void sdc_disable_channel(struct mx3fb_info *= mx3_fbi) > =20 > spin_lock_irqsave(&mx3fb->lock, flags); > =20 > - enabled =3D sdc_fb_uninit(mx3_fbi); > + sdc_fb_uninit(mx3_fbi); > =20 > spin_unlock_irqrestore(&mx3fb->lock, flags); > =20 > @@ -732,7 +731,7 @@ static int mx3fb_unmap_video_memory(struct fb_info = *fbi); > =20 > /** > * mx3fb_set_fix() - set fixed framebuffer parameters from variable s= ettings. > - * @info: framebuffer information pointer > + * @fbi: framebuffer information pointer > * @return: 0 on success or negative error code on failure. > */ > static int mx3fb_set_fix(struct fb_info *fbi) > @@ -740,7 +739,7 @@ static int mx3fb_set_fix(struct fb_info *fbi) > struct fb_fix_screeninfo *fix =3D &fbi->fix; > struct fb_var_screeninfo *var =3D &fbi->var; > =20 > - strncpy(fix->id, "DISP3 BG", 8); > + memcpy(fix->id, "DISP3 BG", 8); > =20 > fix->line_length =3D var->xres_virtual * var->bits_per_pixel / 8; > =20 > @@ -1105,6 +1104,8 @@ static void __blank(int blank, struct fb_info *fb= i) > =20 > /** > * mx3fb_blank() - blank the display. > + * @blank: blank value for the panel > + * @fbi: framebuffer information pointer > */ > static int mx3fb_blank(int blank, struct fb_info *fbi) > { > @@ -1126,7 +1127,7 @@ static int mx3fb_blank(int blank, struct fb_info = *fbi) > /** > * mx3fb_pan_display() - pan or wrap the display > * @var: variable screen buffer information. > - * @info: framebuffer information pointer. > + * @fbi: framebuffer information pointer. > * > * We look only at xoffset, yoffset and the FB_VMODE_YWRAP flag > */ > @@ -1387,6 +1388,8 @@ static int mx3fb_unmap_video_memory(struct fb_inf= o *fbi) > =20 > /** > * mx3fb_init_fbinfo() - initialize framebuffer information object. > + * @dev: the device > + * @ops: framebuffer device operations > * @return: initialized framebuffer structure. > */ > static struct fb_info *mx3fb_init_fbinfo(struct device *dev, >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --gBhdQZ4fzKcCFXCbfYJKRXkfI9yrNiC2e-- --W5ondu2BzooQuN1TJhHShX5xd8qVp4c8s Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/E8hQFAwAAAAAACgkQlh/E3EQov+BP tg//QgEeyxJohypv5p+2dp18uL6+hQhFn2JFqV5/Cpttk8tRB4tbnGljL4Z6T/sx+sfNIafvkvgb 6w5RNP/+pjsyKtwdqlipKW0aPBMseRHgNogBnZ8M7SbsSSZYfre7kip31PgJRQ+jzAHhjdVT5Uao zf1CDP66+HrYd6x9UjZ2NoCiOGl4cjgWb4bV+wssIw0qyoUPerWj4kkKD0AXI8ZolLjxcm9Aqe0Z lirsRyNpu+5+D2WZDhdlG+Ja3L2kX0HUnChCBDv12QpBN1pXkV7KOliu0mn+jPe3Wp5vWSUQyFJ2 ntRDfeQ2mwz5MadWRqr0NwcPV36fDDhE5vpDha+UVxgIJ4uEjve1Z9oV7aPmgZnAF/NOWAt3Ptco 9EOpmvxu4Jw6DefyYzCeyG7f1w52pC2KvLHuUjnCSFO27gCHJwg+ddDtAiCgHUAmvRk+HmXfW5sJ 1x73mpia7d5mPP1K5/DL6s8cMSNwFKVJTnp7bI/rskkGBrG/nhapIXPlVkLaK0JK7G21WfcODSQB y9pj4am0x3sS+oTpO6jLuPdvck6XztaKxx9aERswrVLJrPi/WFrJx+zaVOoOoIDQl2IgNkjC865h qOVpO1526HVsI6QlF7eVB9tC4vQMmf89Jm46goqMn9/+r9Sw9h1fwmmyfJ6fDFc1PUnBiyEGySBD pmc= =FNZb -----END PGP SIGNATURE----- --W5ondu2BzooQuN1TJhHShX5xd8qVp4c8s--