From: "libaokun (A)" <libaokun1@huawei.com>
To: <mbroemme@libmpq.org>, <linux-fbdev@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: <weiyongjun1@huawei.com>, <yuehaibing@huawei.com>,
<yangjihong1@huawei.com>, <yukuai3@huawei.com>
Subject: Re: [PATCH -next] video: fbdev: intelfb: Remove set but not used variable 'val'
Date: Tue, 15 Jun 2021 09:58:35 +0800 [thread overview]
Message-ID: <253d3e4d-c843-df88-5299-7b7b3dfd3c5b@huawei.com> (raw)
In-Reply-To: <20210527085904.3861173-1-libaokun1@huawei.com>
ping
在 2021/5/27 16:59, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setscl':
> drivers/video/fbdev/intelfb/intelfb_i2c.c:58:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setsda':
> drivers/video/fbdev/intelfb/intelfb_i2c.c:69:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/video/fbdev/intelfb/intelfb_i2c.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c
> index 3300bd31d9d7..4df2f1f8a18e 100644
> --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c
> +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c
> @@ -55,22 +55,20 @@ static void intelfb_gpio_setscl(void *data, int state)
> {
> struct intelfb_i2c_chan *chan = data;
> struct intelfb_info *dinfo = chan->dinfo;
> - u32 val;
>
> OUTREG(chan->reg, (state ? SCL_VAL_OUT : 0) |
> SCL_DIR | SCL_DIR_MASK | SCL_VAL_MASK);
> - val = INREG(chan->reg);
> + INREG(chan->reg);
> }
>
> static void intelfb_gpio_setsda(void *data, int state)
> {
> struct intelfb_i2c_chan *chan = data;
> struct intelfb_info *dinfo = chan->dinfo;
> - u32 val;
>
> OUTREG(chan->reg, (state ? SDA_VAL_OUT : 0) |
> SDA_DIR | SDA_DIR_MASK | SDA_VAL_MASK);
> - val = INREG(chan->reg);
> + INREG(chan->reg);
> }
>
> static int intelfb_gpio_getscl(void *data)
prev parent reply other threads:[~2021-06-15 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 8:59 [PATCH -next] video: fbdev: intelfb: Remove set but not used variable 'val' Baokun Li
2021-06-15 1:58 ` libaokun (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253d3e4d-c843-df88-5299-7b7b3dfd3c5b@huawei.com \
--to=libaokun1@huawei.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroemme@libmpq.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).