From: Anshuman Khandual <anshuman.khandual@arm.com>
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@kernel.org>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v1 1/2] video: fbdev: acornfb: remove free_unused_pages()
Date: Thu, 28 Jan 2021 09:24:21 +0530 [thread overview]
Message-ID: <292c749e-427e-0a8d-c163-9f739af873a8@arm.com> (raw)
In-Reply-To: <20210126182113.19892-2-david@redhat.com>
On 1/26/21 11:51 PM, David Hildenbrand wrote:
> This function is never used and it is one of the last remaining user of
> __free_reserved_page(). Let's just drop it.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
There is no other reference for free_unused_pages() in the tree.
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> drivers/video/fbdev/acornfb.c | 34 ----------------------------------
> 1 file changed, 34 deletions(-)
>
> diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c
> index bcc92aecf666..1b72edc01cfb 100644
> --- a/drivers/video/fbdev/acornfb.c
> +++ b/drivers/video/fbdev/acornfb.c
> @@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void)
> return 4;
> }
>
> -/*
> - * This enables the unused memory to be freed on older Acorn machines.
> - * We are freeing memory on behalf of the architecture initialisation
> - * code here.
> - */
> -static inline void
> -free_unused_pages(unsigned int virtual_start, unsigned int virtual_end)
> -{
> - int mb_freed = 0;
> -
> - /*
> - * Align addresses
> - */
> - virtual_start = PAGE_ALIGN(virtual_start);
> - virtual_end = PAGE_ALIGN(virtual_end);
> -
> - while (virtual_start < virtual_end) {
> - struct page *page;
> -
> - /*
> - * Clear page reserved bit,
> - * set count to 1, and free
> - * the page.
> - */
> - page = virt_to_page(virtual_start);
> - __free_reserved_page(page);
> -
> - virtual_start += PAGE_SIZE;
> - mb_freed += PAGE_SIZE / 1024;
> - }
> -
> - printk("acornfb: freed %dK memory\n", mb_freed);
> -}
> -
> static int acornfb_probe(struct platform_device *dev)
> {
> unsigned long size;
>
next prev parent reply other threads:[~2021-01-28 4:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:21 [PATCH v1 0/2] mm: simplify free_highmem_page() and free_reserved_page() David Hildenbrand
2021-01-26 18:21 ` [PATCH v1 1/2] video: fbdev: acornfb: remove free_unused_pages() David Hildenbrand
2021-01-27 8:44 ` Geert Uytterhoeven
2021-01-27 11:53 ` Oscar Salvador
2021-01-28 3:54 ` Anshuman Khandual [this message]
2021-01-26 18:21 ` [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page() David Hildenbrand
2021-01-27 11:51 ` Oscar Salvador
2021-01-27 12:24 ` David Hildenbrand
2021-01-28 4:12 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292c749e-427e-0a8d-c163-9f739af873a8@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=richard.weiyang@linux.alibaba.com \
--cc=rppt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).