linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	William Kucharski <william.kucharski@oracle.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Ian Campbell <ijc@hellion.org.uk>,
	linux-fsdevel@vger.kernel.org,
	Jaya Kumar <jayakumar.lkml@gmail.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] fb_defio: Remove custom address_space_operations
Date: Sun, 30 May 2021 15:40:44 -0700	[thread overview]
Message-ID: <2977064f-42d0-7b64-176d-9509c205bfc3@kernel.org> (raw)
In-Reply-To: <YLQALv2YENIDh77N@casper.infradead.org>

On 5/30/2021 2:14 PM, Matthew Wilcox wrote:
> On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote:
>> Hi Matthew,
>>
>> On Wed, Mar 10, 2021 at 06:55:30PM +0000, Matthew Wilcox (Oracle) wrote:
>>> There's no need to give the page an address_space.  Leaving the
>>> page->mapping as NULL will cause the VM to handle set_page_dirty()
>>> the same way that it's handled now, and that was the only reason to
>>> set the address_space in the first place.
>>>
>>> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
>>
>> This patch in mainline as commit ccf953d8f3d6 ("fb_defio: Remove custom
>> address_space_operations") causes my Hyper-V based VM to no longer make
>> it to a graphical environment.
> 
> Hi Nathan,
> 
> Thanks for the report.  I sent Daniel a revert patch with a full
> explanation last week, which I assume he'll queue up for a pull soon.
> You can just git revert ccf953d8f3d6 for yourself until that shows up.
> Sorry for the inconvenience.
> 

Thank you for the quick response! I will keep an eye out for the patch 
while reverting it locally in the meantime.

Cheers,
Nathan

  reply	other threads:[~2021-05-30 22:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 18:55 Matthew Wilcox (Oracle)
2021-03-11  0:46 ` William Kucharski
2021-03-12 14:12 ` Daniel Vetter
     [not found] ` <YLPjwUUmHDRjyPpR@Ryzen-9-3900X.localdomain>
2021-05-30 21:14   ` Matthew Wilcox
2021-05-30 22:40     ` Nathan Chancellor [this message]
2021-06-01 14:10     ` Daniel Vetter
2021-06-01 14:30       ` Matthew Wilcox
2021-06-01 15:39         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2977064f-42d0-7b64-176d-9509c205bfc3@kernel.org \
    --to=nathan@kernel.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=ijc@hellion.org.uk \
    --cc=jani.nikula@intel.com \
    --cc=jayakumar.lkml@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=william.kucharski@oracle.com \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH v2] fb_defio: Remove custom address_space_operations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).