From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48650C19F2C for ; Thu, 28 Jul 2022 14:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbiG1OwN (ORCPT ); Thu, 28 Jul 2022 10:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbiG1OwM (ORCPT ); Thu, 28 Jul 2022 10:52:12 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFE915D0C0; Thu, 28 Jul 2022 07:52:10 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id v3so1545108wrp.0; Thu, 28 Jul 2022 07:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mD3MJdwe1M/MeC+R1sdMr+F5YiHskPdcW+5CKgvwmK4=; b=iUGg/CrWW+MiUyA/mg1p5vzybXCg3jUouFcnlHWaVGqFxrhWwizVOpH2IkQW7szJma iOC8pfSoe7ZZfKyDF4gvUHQ1mUov9IdU4wV/+Mk1J7/6KN37cdUlC+pfFtyERNyzfFQj XuXVRdDr902PQSnkrr2MmHMUyQOnyMt+G6aCUtLTlLNZevb2z6wAE/CSG6KVdMXRmpm8 ED78UkYZK4M8/tXowcNICLq+pGO/J8ezajSuCEvi2D0KxuSH13LKj59MYbAgyvHaYjcX 0YwhkT39e7Dt+m1ZkNZv8VMP/qameaFdsVlmPPWo0SK5lvvQBzhpDyw+irGhUosn662C rCVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mD3MJdwe1M/MeC+R1sdMr+F5YiHskPdcW+5CKgvwmK4=; b=bkvfragGHb5C/unm0I+wN/tyBhvCcqwbl0jfWiFoVDwJKnOTmtvN8jNS3B2ZWPUQBK coQUcnzK+lM00aoFM/4YdOqNInaIZ3YKxbjlfW3q/VeXQIXaCm+YpcDmwaRDEsrS00Ay RrY+ALc+psF+YKibTNOURFfcmLJGoA1+jbMLLByM5mEqG038WExtK7wZkGzGBhWRR+8+ tYLjv3rUO/ZlsrmVc7w+q1gsz68bCSRv+LmJQtFYl6S0Z7CpcBjyoD7Xx2Yi1TgI/+Zt LZOKgEtRsv4rxdZEfOljRUEuV12S64rgsajdMZFvatLfcHc6gir8vidqVku6CaT9CWxS fFSw== X-Gm-Message-State: AJIora/GtUbQecyp0m4dfE6gsfvP2JboJx5qU2HzWBHWGSdmJfm9qQ/6 gJWb4v0LsGTQfov6hS48h2c= X-Google-Smtp-Source: AGRyM1sGc5o3vzAllmoqiOc4kg6oAhY9pYH2gIOcTuw0tQ66DwxqCUNnE+4m3BL7R0boMJmgLYXsBg== X-Received: by 2002:a05:6000:1f0e:b0:21e:87c9:6b55 with SMTP id bv14-20020a0560001f0e00b0021e87c96b55mr13834716wrb.326.1659019929483; Thu, 28 Jul 2022 07:52:09 -0700 (PDT) Received: from [0.0.0.0] ([185.246.188.60]) by smtp.gmail.com with ESMTPSA id q14-20020adff94e000000b0021d7b41255esm1122958wrr.98.2022.07.28.07.52.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 07:52:09 -0700 (PDT) Message-ID: <30ce6f21-0a91-81cb-8b03-5acff17c59ee@gmail.com> Date: Thu, 28 Jul 2022 17:52:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem Content-Language: en-US To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Jonathan Corbet , Ard Biesheuvel , Jiri Slaby , Helge Deller , "Paul E. McKenney" , Borislav Petkov , Andrew Morton , Kees Cook , Randy Dunlap , Damien Le Moal , Thomas Zimmermann , Javier Martinez Canillas , Michal Suchanek , Andy Shevchenko , Arnd Bergmann , Wei Ming Chen , Bartlomiej Zolnierkiewicz , Tony Lindgren , linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring References: <20220728142824.3836-1-markuss.broks@gmail.com> <20220728142824.3836-3-markuss.broks@gmail.com> From: Markuss Broks In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Greg, On 7/28/22 17:39, Greg Kroah-Hartman wrote: > On Thu, Jul 28, 2022 at 05:28:19PM +0300, Markuss Broks wrote: >> Add early console support for generic linear framebuffer devices. >> This driver supports probing from cmdline early parameters >> or from the device-tree using information in simple-framebuffer node. >> The EFI functionality should be retained in whole. >> The driver was disabled on ARM because of a bug in early_ioremap >> implementation on ARM. >> >> Signed-off-by: Markuss Broks >> --- >> .../admin-guide/kernel-parameters.txt | 12 +- >> MAINTAINERS | 5 + >> drivers/firmware/efi/Kconfig | 6 +- >> drivers/firmware/efi/Makefile | 1 - >> drivers/firmware/efi/earlycon.c | 246 -------------- >> drivers/video/fbdev/Kconfig | 11 + >> drivers/video/fbdev/Makefile | 1 + >> drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++ >> 8 files changed, 327 insertions(+), 256 deletions(-) >> delete mode 100644 drivers/firmware/efi/earlycon.c >> create mode 100644 drivers/video/fbdev/earlycon.c > > That should be a rename, not a delete/create, right? Should this change be split into two separate commits, one for moving the file and the second for making changes? > > thanks, > > greg k-h - Markuss