linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Wei Chen <harperchen1110@gmail.com>, deller@gmx.de
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbdev: au1200fb: Fix potential divide by zero
Date: Wed, 15 Mar 2023 11:25:52 +0100	[thread overview]
Message-ID: <360b814b-40e0-5444-8d6b-1e29719e4414@suse.de> (raw)
In-Reply-To: <20230315092254.1042615-1-harperchen1110@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1490 bytes --]

Hi,

thanks for looking through these drivers.

Am 15.03.23 um 10:22 schrieb Wei Chen:
> var->pixclock can be assigned to zero by user. Without
> proper check, divide by zero would occur when invoking
> macro PICOS2KHZ in au1200fb_fb_check_var.
> 
> Error out if var->pixclock is zero.
> 
> Signed-off-by: Wei Chen <harperchen1110@gmail.com>
> ---
>   drivers/video/fbdev/au1200fb.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c
> index 81c315454428..b6b22fa4a8a0 100644
> --- a/drivers/video/fbdev/au1200fb.c
> +++ b/drivers/video/fbdev/au1200fb.c
> @@ -1040,6 +1040,9 @@ static int au1200fb_fb_check_var(struct fb_var_screeninfo *var,
>   	u32 pixclock;
>   	int screen_size, plane;
>   
> +	if (!var->pixclock)
> +		return -EINVAL;
> +

Instead of the whale-a-mole approach of fixing individual drivers, could 
this be solved by testing in fb_set_var [1] and fb_try_mode.? [2]

Best regards
Thomas

[1] 
https://elixir.bootlin.com/linux/latest/source/drivers/video/fbdev/core/fbmem.c#L958
[2] 
https://elixir.bootlin.com/linux/latest/source/drivers/video/fbdev/core/modedb.c#L567

>   	plane = fbdev->plane;
>   
>   	/* Make sure that the mode respect all LCD controller and

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2023-03-15 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  9:22 [PATCH] fbdev: au1200fb: Fix potential divide by zero Wei Chen
2023-03-15 10:25 ` Thomas Zimmermann [this message]
2023-03-15 12:27   ` Wei Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=360b814b-40e0-5444-8d6b-1e29719e4414@suse.de \
    --to=tzimmermann@suse.de \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harperchen1110@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).