From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CEBC433FE for ; Mon, 7 Dec 2020 13:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D09C23436 for ; Mon, 7 Dec 2020 13:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726035AbgLGNxU (ORCPT ); Mon, 7 Dec 2020 08:53:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:52914 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgLGNxT (ORCPT ); Mon, 7 Dec 2020 08:53:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 113EEACF4; Mon, 7 Dec 2020 13:52:38 +0000 (UTC) Subject: Re: [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-13-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <39bdf3e7-8c44-251c-3d07-bccaf0b57232@suse.de> Date: Mon, 7 Dec 2020 14:52:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-13-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7K9RMvebdbUZW5Z8ipJPNeE2ljwGrAkkJ" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7K9RMvebdbUZW5Z8ipJPNeE2ljwGrAkkJ Content-Type: multipart/mixed; boundary="n6kugew9TCJp3NJ23QFcuxsfIQBOknSrz"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: <39bdf3e7-8c44-251c-3d07-bccaf0b57232@suse.de> Subject: Re: [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-13-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-13-sam@ravnborg.org> --n6kugew9TCJp3NJ23QFcuxsfIQBOknSrz Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > The controlfb driver has a number of dummy defines for IO operations. > They were introduced in commit a07a63b0e24d > ("video: fbdev: controlfb: add COMPILE_TEST support"). >=20 > The write variants did not use their value parameter in the > dummy versions, resulting in set but not used warnings. > Fix this by adding "(void)val" to silence the compiler. >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg > Cc: Bartlomiej Zolnierkiewicz > Cc: "Gustavo A. R. Silva" > Cc: Michael Ellerman Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/controlfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/cont= rolfb.c > index 2df56bd303d2..509311471d51 100644 > --- a/drivers/video/fbdev/controlfb.c > +++ b/drivers/video/fbdev/controlfb.c > @@ -64,9 +64,9 @@ > #undef in_le32 > #undef out_le32 > #define in_8(addr) 0 > -#define out_8(addr, val) > +#define out_8(addr, val) (void)(val) > #define in_le32(addr) 0 > -#define out_le32(addr, val) > +#define out_le32(addr, val) (void)(val) > #define pgprot_cached_wthru(prot) (prot) > #else > static void invalid_vram_cache(void __force *addr) >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --n6kugew9TCJp3NJ23QFcuxsfIQBOknSrz-- --7K9RMvebdbUZW5Z8ipJPNeE2ljwGrAkkJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/OM6QFAwAAAAAACgkQlh/E3EQov+Cp gQ//Z2QKFAITQMWsqXXo2zB5IeIxT6rELs2iruFBMadE1p9VDaev0xMKR2Yf2OptQeUPWbbpbd56 py+pHfi1aiZmZHXqLBZDwB+SWYawtohNIjUzPBdTM8LPpjOlZxKnJmsa+viwiR4gaGQEzsAF9rrS Iuozg0Fn6BYZpyhTB6yxmPm1hpKhANnwyfYQ3Cerpf2M9uBAWZXC3tDiUjVvWPKkVMPxPd12dtem 6SdE8bsrabncw5E9v562iC3TUUiyVO9oHPbpsJ34K2ZxXl7jblvRcfyBY9DVlzJ6514c9WkZT/6A bp2COOW2LHq7aGiXRHjKKADagWFo0pqcNAOObyUQqJY0Rtw8UkdqExtd65q4kPmezvBF213EtQ+i lcXbpurreLx77VCRNZEp4Ezj72znNmWRX7EgLSiLFdm8e6GyA3QNbYlkXc3x286h4jD8xip1q10o yFHUCjI96lSvKuNAeRsTUjgfi/rLC+DqqgnWKosW8DoyFeO7sTt08vCNmQF3EdoCErW9rp70+r42 mH39aAouj54lnjkhGFI3X2FEGI5oY5zb6mcF/UzK5YVfb+jD85mKHLp5xJM256FUiFNqe/jdAymo RTVgpeWpPOQSWPGWuMqe6CRZArIDN/ktwtP6HXU0evK+6NlJpQt21+Kb0uy0BywPzSA4xGfcfNGo 5NQ= =rPLK -----END PGP SIGNATURE----- --7K9RMvebdbUZW5Z8ipJPNeE2ljwGrAkkJ--