Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Lee Jones <lee.jones@linaro.org>
Cc: Alexander Klimov <grandmaster@al2klimov.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Colin Ian King <colin.king@canonical.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Douglas Anderson <dianders@chromium.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Gustavo A R Silva <gustavoars@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	linux-arm-kernel@lists.infradead.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mike Rapoport <rppt@kernel.org>, Peter Jones <pjones@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Qilong Zhang <zhangqilong3@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Rich Felker <dalias@libc.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Winischhofer <thomas@winischhofer.net>,
	Tony Prisk <linux@prisktech.co.nz>,
	Michal Januszewski <spock@gentoo.org>
Subject: Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning
Date: Mon, 7 Dec 2020 09:18:20 +0100	[thread overview]
Message-ID: <3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de> (raw)
In-Reply-To: <20201206190247.1861316-5-sam@ravnborg.org>


[-- Attachment #1.1: Type: text/plain, Size: 1257 bytes --]


Am 06.12.20 um 20:02 schrieb Sam Ravnborg:
> Fix W=1 warning by deleting unused local variable.
> 
> v2:
>    - Updated subject (Lee)
> 
> v3:
>    - Return early in case of an error (Thomas)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Michal Januszewski <spock@gentoo.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Lee Jones <lee.jones@linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/uvesafb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index 6c9cfab39313..4df6772802d7 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
>   	task->t.regs.eax = 0x4f0a;
>   	task->t.regs.ebx = 0x0;
>   	err = uvesafb_exec(task);
> +	if (err)
> +		return err;
>   
>   	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
>   		par->pmi_setpal = par->ypan = 0;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]