From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6226EC433FE for ; Mon, 7 Dec 2020 08:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16963229C6 for ; Mon, 7 Dec 2020 08:19:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbgLGITE (ORCPT ); Mon, 7 Dec 2020 03:19:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:42752 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgLGITE (ORCPT ); Mon, 7 Dec 2020 03:19:04 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF387AC90; Mon, 7 Dec 2020 08:18:22 +0000 (UTC) Subject: Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk , Michal Januszewski References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-5-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de> Date: Mon, 7 Dec 2020 09:18:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-5-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LJMSVNL2afwccTQRS66KkxLg28hS8Od5u" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LJMSVNL2afwccTQRS66KkxLg28hS8Od5u Content-Type: multipart/mixed; boundary="wYeFGUNpMsCjQ1j0u8ZG1rJkwO3PFHGp2"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk , Michal Januszewski Message-ID: <3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de> Subject: Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-5-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-5-sam@ravnborg.org> --wYeFGUNpMsCjQ1j0u8ZG1rJkwO3PFHGp2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > Fix W=3D1 warning by deleting unused local variable. >=20 > v2: > - Updated subject (Lee) >=20 > v3: > - Return early in case of an error (Thomas) >=20 > Signed-off-by: Sam Ravnborg > Cc: Michal Januszewski > Cc: linux-fbdev@vger.kernel.org > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/uvesafb.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesaf= b.c > index 6c9cfab39313..4df6772802d7 100644 > --- a/drivers/video/fbdev/uvesafb.c > +++ b/drivers/video/fbdev/uvesafb.c > @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask = *task, > task->t.regs.eax =3D 0x4f0a; > task->t.regs.ebx =3D 0x0; > err =3D uvesafb_exec(task); > + if (err) > + return err; > =20 > if ((task->t.regs.eax & 0xffff) !=3D 0x4f || task->t.regs.es < 0xc00= 0) { > par->pmi_setpal =3D par->ypan =3D 0; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --wYeFGUNpMsCjQ1j0u8ZG1rJkwO3PFHGp2-- --LJMSVNL2afwccTQRS66KkxLg28hS8Od5u Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/N5UwFAwAAAAAACgkQlh/E3EQov+Av 3g//cysUamSEEJE8FPFeFSFi8GL52DSPYZwpij7YlTgJV9rQ/qHzho240/Wy+3R7jxFzPp3T/3dh dzEkog+FVVxT4tYZWsnX0q1+6suL1JNc4mAK3/Q5c/fu/0yqaNI16RVgTQEAm4/LqP3kA10VsumD waCo0Vre61lf6XxGH1KXsnV9gvMsO8G/NwJjpAyz1e5Yh/rhohZ3vPbWyUq4+OywPYlDbVlaHyhw u/PS1/v9lgBHrDMYvKp+a/W6QQeZJfy/WTzP7oSq0naGcns19h34UaydZinkvErs+EPZNKNAyV58 5n1syDBNeHIdkWZh2FsfwrfFIbLDEEvGOvx79SSdy48H6pJ173CWPo6PGupjfNgDS3GrIgIApV9q COxRDX4C6QSLfs4bV8Ist4+PeRQG1NiuJ0OaBUA8CT0AZ2pqxtXUqz4iCkumTLihfbaDAFe9no/J KIUn63ZA9ULge42WfDSI4qtkfRfKuVt2TIQ2y4uGFNOoJ4zzQ6AvcpwMjWtulj66+0YOqSMhDORi y3kKdbCjZuqANgC++rWrEWiZSGf+qbWwbzzYMgMQsdu5PxpMnGnFWBGeMRuPJenroBizEZzV9NKU nvYDQKfXiz70mt4vr9VqxSNu2orFvtHAOhbG9Yhh0nrx6maXPDDnqzpKrTkqC3IV9VvJhK81o3G2 yic= =iTkE -----END PGP SIGNATURE----- --LJMSVNL2afwccTQRS66KkxLg28hS8Od5u--