From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4915AC433E0 for ; Wed, 27 Jan 2021 13:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05239207A2 for ; Wed, 27 Jan 2021 13:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S313172AbhAZWg4 (ORCPT ); Tue, 26 Jan 2021 17:36:56 -0500 Received: from foss.arm.com ([217.140.110.172]:48778 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729902AbhAZRL2 (ORCPT ); Tue, 26 Jan 2021 12:11:28 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 843DFD6E; Tue, 26 Jan 2021 09:08:55 -0800 (PST) Received: from [10.57.40.145] (unknown [10.57.40.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 099A63F66E; Tue, 26 Jan 2021 09:08:45 -0800 (PST) Subject: Re: [PATCH v3 4/5] amba: Make the remove callback return void To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Russell King , Matt Mackall , Herbert Xu , Vinod Koul , Dan Williams , Eric Anholt , David Airlie , Daniel Vetter , Mathieu Poirier , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Dmitry Torokhov , Vladimir Zapolskiy , Krzysztof Kozlowski , Ulf Hansson , Alessandro Zummo , Alexandre Belloni , Mark Brown , Greg Kroah-Hartman , Jiri Slaby , Eric Auger , Alex Williamson , Cornelia Huck , Wim Van Sebroeck , Guenter Roeck , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, Mike Leach , Leo Yan , Arnd Bergmann , linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, kvm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org References: <20210126165835.687514-1-u.kleine-koenig@pengutronix.de> <20210126165835.687514-5-u.kleine-koenig@pengutronix.de> From: Suzuki K Poulose Message-ID: <3e42b2ea-c713-31b2-9c86-c49a70d8e1f4@arm.com> Date: Tue, 26 Jan 2021 17:08:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210126165835.687514-5-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi On 1/26/21 4:58 PM, Uwe Kleine-König wrote: > All amba drivers return 0 in their remove callback. Together with the > driver core ignoring the return value anyhow, it doesn't make sense to > return a value here. > > Change the remove prototype to return void, which makes it explicit that > returning an error value doesn't work as expected. This simplifies changing > the core remove callback to return void, too. > > Reviewed-by: Ulf Hansson > Reviewed-by: Arnd Bergmann > Acked-by: Alexandre Belloni > Acked-by: Dmitry Torokhov > Acked-by: Krzysztof Kozlowski # for drivers/memory > Acked-by: Mark Brown > Acked-by: Dmitry Torokhov > Acked-by: Linus Walleij > Signed-off-by: Uwe Kleine-König > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +--- You are most likely to have a conflict for the above file, with what is in coresight/next. It should be easy to resolve. Otherwise, the changes look good for the drivers/hwtracing/coresight/* Acked-by: Suzuki K Poulose