From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5ECC47096 for ; Thu, 3 Jun 2021 06:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBBFD613E6 for ; Thu, 3 Jun 2021 06:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhFCG2L (ORCPT ); Thu, 3 Jun 2021 02:28:11 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:55098 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbhFCG2L (ORCPT ); Thu, 3 Jun 2021 02:28:11 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1622701586; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=JQ5eM5aH4kIpWWTZt6DlDA3K6TzSLosXUzhL8Jtxdjs=; b=XxTje0pLEQu9lT4iB87OkaZiwRq5w9TYojmDEX35Jkk/6PnvH/VX4ZmtptF1dPly+fdwu7fT mAklk6d19IYqaacaLcst4WsaspaDieEqFrIEZMjfRYRym13iTLU1IKURtwhEhmO5DEFSZ6mL eo/zdpxxgbBmNtd8rBmyJ5AQi0A= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI4YmIzMiIsICJsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 60b87612f726fa41881220c6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 03 Jun 2021 06:26:26 GMT Sender: rajeevny=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 41F6DC4360C; Thu, 3 Jun 2021 06:26:25 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rajeevny) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5B7A8C433D3; Thu, 3 Jun 2021 06:26:24 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 03 Jun 2021 11:56:24 +0530 From: rajeevny@codeaurora.org To: Doug Anderson Cc: dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org Subject: Re: [v5 1/5] drm/panel: add basic DP AUX backlight support In-Reply-To: References: <1622390172-31368-1-git-send-email-rajeevny@codeaurora.org> <1622390172-31368-2-git-send-email-rajeevny@codeaurora.org> Message-ID: <3f088fcc07800323b4cb24af4b972514@codeaurora.org> X-Sender: rajeevny@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 03-06-2021 05:35, Doug Anderson wrote: > Hi, > > On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan > wrote: >> > > Other than the two nits (ordering of memory allocation and word > wrapping in a comment), this looks good to me. Feel free to add my > Reviewed-by tag when you fix the nits. > > NOTE: Even though I have commit access to drm-misc now, I wouldn't > feel comfortable merging this to drm-misc myself without review > feedback from someone more senior. Obviously we're still blocked on my > and Lyude's series landing first, but even assuming those just land > as-is we'll need some more adult supervision before this can land. ;-) > That being said, I personally think this looks pretty nice now. > > > -Doug Thank you, Doug. I'll address the review comments of this patch and another patch (v5 3/5) in the next spin. I'll wait for Lyude to check this series, as she wanted to review it in a few days. Thanks, Rajeev