From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCB1C64E7A for ; Tue, 1 Dec 2020 10:10:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 810D8206F9 for ; Tue, 1 Dec 2020 10:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbgLAKJx (ORCPT ); Tue, 1 Dec 2020 05:09:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:49178 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729016AbgLAKJw (ORCPT ); Tue, 1 Dec 2020 05:09:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F1DC5ACF4; Tue, 1 Dec 2020 10:09:10 +0000 (UTC) Subject: Re: [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Vaibhav Gupta , Tetsuo Handa , Michal Januszewski , Laurent Pinchart , Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Peter Rosin , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peilin Ye , Mike Rapoport References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-26-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <4191b9d7-3e53-7a0e-4d8d-c9c9ec8fa814@suse.de> Date: Tue, 1 Dec 2020 11:09:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-26-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BuBuE6ETJyeoXrRgBLrPpxKOQ3jUnffHZ" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BuBuE6ETJyeoXrRgBLrPpxKOQ3jUnffHZ Content-Type: multipart/mixed; boundary="21zkJXPzm2sRL4MSqPz0EfFefti2Tgxqs"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Vaibhav Gupta , Tetsuo Handa , Michal Januszewski , Laurent Pinchart , Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Peter Rosin , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peilin Ye , Mike Rapoport Message-ID: <4191b9d7-3e53-7a0e-4d8d-c9c9ec8fa814@suse.de> Subject: Re: [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-26-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-26-sam@ravnborg.org> --21zkJXPzm2sRL4MSqPz0EfFefti2Tgxqs Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > Fix W=3D1 warning by deleting unused local variable. >=20 > v2: > - Updated subject (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Michal Januszewski > Cc: linux-fbdev@vger.kernel.org > Cc: Lee Jones > --- > drivers/video/fbdev/uvesafb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesaf= b.c > index def14ac0ebe1..8ee0fc9c63cf 100644 > --- a/drivers/video/fbdev/uvesafb.c > +++ b/drivers/video/fbdev/uvesafb.c > @@ -554,12 +554,12 @@ static int uvesafb_vbe_getmodes(struct uvesafb_kt= ask *task, > static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task, > struct uvesafb_par *par) > { > - int i, err; > + int i; > =20 > uvesafb_reset(task); > task->t.regs.eax =3D 0x4f0a; > task->t.regs.ebx =3D 0x0; > - err =3D uvesafb_exec(task); > + uvesafb_exec(task); Would it be better to report the error here? Best regards Thomas > =20 > if ((task->t.regs.eax & 0xffff) !=3D 0x4f || task->t.regs.es < 0xc00= 0) { > par->pmi_setpal =3D par->ypan =3D 0; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --21zkJXPzm2sRL4MSqPz0EfFefti2Tgxqs-- --BuBuE6ETJyeoXrRgBLrPpxKOQ3jUnffHZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/GFkIFAwAAAAAACgkQlh/E3EQov+Bh nQ//QFyXRggNsYo5mmiPC0E2RpBFOtWJ9nC9wPMtHglPPpVAf+tIzyOBl18Gk6WBdTf1EgYzWiVM jt1dxCl2Rsg0wW88VVIJ+f29Asqm/agu4k4RUlxdYugtdksW8tiC6LbyXyiLVO8I2YOP6c9dH/h7 qaS3c8tqqKpLSyIgs/kT61Pm3ytLiDoixX5XMGxheaMDuTD/G5F72/zig3MfsUULkyTPPEVOQizV n0qIYmAwzZuxQ+7LjX2+Wdtk354/haz9uETulwdnnmJApLo7iWD4INmoUYqJp/xLv7CXzD1uYfuD Jbdd6ejosa5PmOSAcLyppMxxUtqO9jAGcnTN0GqokLdCsNebh9pq+cFP0hO4OC7+Af+Mr4H3tEmn UfPjvllIHtImiyg+17rdVdle0TDzNgT+MU416MF6RqlMqSJJxrpGjJiFIyYtSZbx/ZPg8RlypRzT YYhvSKqYjs2ANYn6JOqTXTOwPqpcd3xIyPBgXZSivjYm3miEcBW+2GAoWYliA5o1MGUxmWdQAdZs q/RRhjJD+uy2/LrAmyf8Ez5BvlGAvz8pmy+Pr2GdX5o1WD0bhR1G9Bwy4h1gJpj7Dk2E43lS1B9p JaCt8w8NWtk1U5WBFq3soRhxGkjYtugsUfpxMRyqzxq9kwizzq9MRRk36dXpevDhHJFBn24I3WpV u9k= =45uM -----END PGP SIGNATURE----- --BuBuE6ETJyeoXrRgBLrPpxKOQ3jUnffHZ--