From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C7EC43381 for ; Wed, 27 Jan 2021 12:29:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C019620791 for ; Wed, 27 Jan 2021 12:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237011AbhA0M3c (ORCPT ); Wed, 27 Jan 2021 07:29:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48437 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236120AbhA0MZw (ORCPT ); Wed, 27 Jan 2021 07:25:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611750264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ESk4erADjhVygeBOZ67K4CNLftTWe14rVACW2LGonko=; b=bMTZXhTTCfoIRCgd/jdHAbKvEusNn7IuZqxdC9v4CL+Qa4JFHbH4y8J6b/yg113Caly5QO IUlKqNDZHUmhYZa1NHIZgcBcuRg4Tfe8/miVHDd/sNSpuaeRHutZ5DFg3ICdzhA6mjWhb3 5HlMfgSazYWrhrHNXDQL/5eQ0DfelfM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-qzwcez55O3y-wZw4QM2TmA-1; Wed, 27 Jan 2021 07:24:20 -0500 X-MC-Unique: qzwcez55O3y-wZw4QM2TmA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 754479CDA2; Wed, 27 Jan 2021 12:24:18 +0000 (UTC) Received: from [10.36.114.237] (ovpn-114-237.ams2.redhat.com [10.36.114.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4AC0A60854; Wed, 27 Jan 2021 12:24:15 +0000 (UTC) Subject: Re: [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton , Thomas Gleixner , "Peter Zijlstra (Intel)" , Mike Rapoport , Michal Hocko , Wei Yang References: <20210126182113.19892-1-david@redhat.com> <20210126182113.19892-3-david@redhat.com> <20210127115122.GA28728@linux> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <4cbbb828-016b-db98-485b-60239041cc07@redhat.com> Date: Wed, 27 Jan 2021 13:24:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210127115122.GA28728@linux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 27.01.21 12:51, Oscar Salvador wrote: > On Tue, Jan 26, 2021 at 07:21:13PM +0100, David Hildenbrand wrote: >> adjust_managed_page_count() as called by free_reserved_page() properly >> handles pages in a highmem zone, so we can reuse it for >> free_highmem_page(). >> >> We can now get rid of totalhigh_pages_inc() and simplify >> free_reserved_page(). >> >> Cc: Andrew Morton >> Cc: Thomas Gleixner >> Cc: "Peter Zijlstra (Intel)" >> Cc: Mike Rapoport >> Cc: Oscar Salvador >> Cc: Michal Hocko >> Cc: Wei Yang >> Signed-off-by: David Hildenbrand > > Reviewed-by: Oscar Salvador > >> +#define free_highmem_page(page) free_reserved_page(page) > > Should we place that under #ifdef CONFIG_HIGHMEM to make clear > that it is only used on that config? > Maybe the #ifdefery ugliness does not pay off. Yeah, most probably not worth it. -- Thanks, David / dhildenb