linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
	shawnguo@kernel.org, festevam@gmail.com, linux-imx@nxp.com,
	j.beisert@pengutronix.de, krzysztof.h1@poczta.fm,
	linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message
Date: Fri, 7 May 2021 09:11:19 +0200	[thread overview]
Message-ID: <5cd9c8de-acd9-9594-38a0-62ecf5734c10@wanadoo.fr> (raw)
In-Reply-To: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de>

Le 07/05/2021 à 07:05, Uwe Kleine-König a écrit :
> Hello Christophe,
> 
> On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:
>> 'ret' is known to be 0 here.
>> No error code is available, so just remove it from the error message.
>>
>> Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direct pointer deref")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   drivers/video/fbdev/imxfb.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
>> index 7f8debd2da06..ad598257ab38 100644
>> --- a/drivers/video/fbdev/imxfb.c
>> +++ b/drivers/video/fbdev/imxfb.c
>> @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev)
>>   	info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size,
>>   					   &fbi->map_dma, GFP_KERNEL);
>>   	if (!info->screen_buffer) {
>> -		dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret);
>> +		dev_err(&pdev->dev, "Failed to allocate video RAM\n");
>>   		ret = -ENOMEM;
>>   		goto failed_map;
>>   	}
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Are you using this driver, or did you find that problem using some
> static checker?
> 

No, I'm not using this driver AFAIK.

It has been spotted by coccinelle with a hand-made script which tries to 
find places where error code is used before being initialized.

The script in it-self is not really interesting. It is easy to write and 
my own version trigger way to much false positives.

CJ

> Best regards
> Uwe
> 


  reply	other threads:[~2021-05-07  7:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 18:57 Christophe JAILLET
2021-05-07  5:05 ` Uwe Kleine-König
2021-05-07  7:11   ` Christophe JAILLET [this message]
2021-05-07  8:20     ` Uwe Kleine-König
2021-05-07 16:34   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cd9c8de-acd9-9594-38a0-62ecf5734c10@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=j.beisert@pengutronix.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --subject='Re: [PATCH] video: fbdev: imxfb: Fix an error message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).