From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064DAC64E7B for ; Mon, 30 Nov 2020 12:13:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B37D42074A for ; Mon, 30 Nov 2020 12:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbgK3MNE (ORCPT ); Mon, 30 Nov 2020 07:13:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:36554 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgK3MND (ORCPT ); Mon, 30 Nov 2020 07:13:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1D02AAF78; Mon, 30 Nov 2020 12:12:20 +0000 (UTC) Subject: Re: [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-13-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <5e7d4fe6-f122-b3c3-5153-f7a043fac252@suse.de> Date: Mon, 30 Nov 2020 13:12:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-13-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H1pNz1Elz7LVf4Sn0jD1Ry5loFKxl2a9x" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H1pNz1Elz7LVf4Sn0jD1Ry5loFKxl2a9x Content-Type: multipart/mixed; boundary="MLWjn68f199HTOUtQqnGmFli3oa1czEK3"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan Message-ID: <5e7d4fe6-f122-b3c3-5153-f7a043fac252@suse.de> Subject: Re: [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-13-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-13-sam@ravnborg.org> --MLWjn68f199HTOUtQqnGmFli3oa1czEK3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > The tmp variable were assigned but the result was never used, s/were/was > so delete the tmp variable. >=20 > v2: > - Update subject (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: "Gustavo A. R. Silva" > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Arnd Bergmann > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/tdfxfb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.= c > index f056d80f6359..67e37a62b07c 100644 > --- a/drivers/video/fbdev/tdfxfb.c > +++ b/drivers/video/fbdev/tdfxfb.c > @@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 = idx) > =20 > static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val) > { > - unsigned char tmp; > - > - tmp =3D vga_inb(par, IS1_R); > + vga_inb(par, IS1_R); It resets the attribute register's state. Hopefully, this doesn't get=20 optimized away. > vga_outb(par, ATT_IW, idx); > vga_outb(par, ATT_IW, val); > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --MLWjn68f199HTOUtQqnGmFli3oa1czEK3-- --H1pNz1Elz7LVf4Sn0jD1Ry5loFKxl2a9x Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/E4Z0FAwAAAAAACgkQlh/E3EQov+Cs tA//S8QSJ0is79uDuav9im2IRaELRa0n+5yT+H8IV36E5mnl5scFbpT2IZwPToO1Rr2UG1b+yIGf 70ZM3CwrnFS4XsILGZ4bWzKL+NGYr+SMeCL1qfCkYXymz2MYpcSp2pmRKanbFH6NALwrTCATe/Zt kwVB1cDQj5+4wqQq6y6eexbO0EWckd9zqMrGPHs+S7mKVh5vd0na0TzASwaPK0X57bqE4vbbBKLV htCvD+eZGvUKCXXcp9JxEmj8BrHPEymDxBbk8pWN6EB1pXPf9l5NAt77nRT/E4YPeBbFN9xTAOhC yzCW42sS5ViaGWged9t/ad9vNTLIjAyDyYiNaSDxfcebbLh9G96OPkLhJRSUhCfKyz3bK186xm+u Qm++5hoGBDs9HUV8MTqeRD7W2vVCqK+mqXob0xYDwJ1Gz4LoAZNfzTuxLvT1/6gKtas6ARBwwi5j MZllzY1I/5WxVFchcTiH1mkRtM/TKfHDbNCnRTKkC2gXAjJ7nXSUO1rmGxxIf2yo429TSFMB44oU tfvqYkVGF30HWoDu1eLH9l6sBANvxcU4u0fIR9W7lOcYkQFDjVfeAp00X4xEhdAGux5XyOFVvJpM rQhPDGWRZ+mnvokGPEtjr8+/FlYwgVyp7cLiWdWMvDy2kM/iBNJ9s8B8zY7OZhaWQskvsyRD+At1 5V0= =lzhd -----END PGP SIGNATURE----- --H1pNz1Elz7LVf4Sn0jD1Ry5loFKxl2a9x--