From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353A1C433E9 for ; Mon, 22 Feb 2021 08:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC77A64E24 for ; Mon, 22 Feb 2021 08:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230396AbhBVIIj (ORCPT ); Mon, 22 Feb 2021 03:08:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:52930 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbhBVII2 (ORCPT ); Mon, 22 Feb 2021 03:08:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8FF14AF59; Mon, 22 Feb 2021 08:07:46 +0000 (UTC) Subject: Re: [PATCH] efifb: Ensure graphics device for efifb stays at PCI D0 To: Kai-Heng Feng , pjones@redhat.com Cc: Alex Deucher , Hans de Goede , "open list:EFIFB FRAMEBUFFER DRIVER" , open list , "open list:FRAMEBUFFER LAYER" References: <20210129084327.986630-1-kai.heng.feng@canonical.com> From: Thomas Zimmermann Message-ID: <5f2dfeb9-7600-2426-bd50-0da48eb72b5f@suse.de> Date: Mon, 22 Feb 2021 09:07:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kkjvE4ePNJC9ui3YvsjoIitrxUNRBbqUE" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kkjvE4ePNJC9ui3YvsjoIitrxUNRBbqUE Content-Type: multipart/mixed; boundary="Wrd47MzSapqF5RXxa0t5fv0RaF2SAKqli"; protected-headers="v1" From: Thomas Zimmermann To: Kai-Heng Feng , pjones@redhat.com Cc: Alex Deucher , Hans de Goede , "open list:EFIFB FRAMEBUFFER DRIVER" , open list , "open list:FRAMEBUFFER LAYER" Message-ID: <5f2dfeb9-7600-2426-bd50-0da48eb72b5f@suse.de> Subject: Re: [PATCH] efifb: Ensure graphics device for efifb stays at PCI D0 References: <20210129084327.986630-1-kai.heng.feng@canonical.com> In-Reply-To: --Wrd47MzSapqF5RXxa0t5fv0RaF2SAKqli Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 22.02.21 um 08:08 schrieb Kai-Heng Feng: > On Mon, Feb 1, 2021 at 11:21 PM Alex Deucher wr= ote: >> >> On Sat, Jan 30, 2021 at 6:27 AM Kai-Heng Feng >> wrote: >>> >>> We are seeing root ports on some desktop boards support D3cold for >>> discrete graphics card. So when efifb is in use while graphics device= >>> isn't bound to a driver, PCI and ACPI will put the graphics to D3cold= >>> when runtime suspend kicks in, makes efifb stop working. >>> >>> So ensure the graphics device won't be runtime suspended, to keep efi= fb >>> work all the time. >>> >>> Signed-off-by: Kai-Heng Feng >> >> Reviewed-by: Alex Deucher >=20 > A gentle ping... Thanks for your patch. I've added it to drm-misc-next. Best regards Thomas >=20 >> >>> --- >>> drivers/video/fbdev/efifb.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.= c >>> index e57c00824965..19edd7206409 100644 >>> --- a/drivers/video/fbdev/efifb.c >>> +++ b/drivers/video/fbdev/efifb.c >>> @@ -16,6 +16,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include