linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kgunda@codeaurora.org
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com,
	lee.jones@linaro.org, b.zolnierkie@samsung.com,
	dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com,
	pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5
Date: Fri, 26 Feb 2021 12:01:28 +0530	[thread overview]
Message-ID: <6ab55df25e193718c143964dda085d8c@codeaurora.org> (raw)
In-Reply-To: <20210224111505.37t5aq25iszg23iv@maple.lan>

On 2021-02-24 16:45, Daniel Thompson wrote:
> On Wed, Feb 24, 2021 at 09:20:47AM +0530, Kiran Gunda wrote:
>> Currently, for WLED5, after FSC register update MOD_SYNC_BIT
>> is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled
>> after the brightness update and SYNC_BIT has to be toggled after
>> FSC update for WLED5. Fix it.
> 
> Code looks fine but the description is a difficult to read (which makes
> mining the history difficult).
> 
> Basically the descriptions here are very hard to read without the
> context in PATCH 0/2. Since PATCH 0/2 won't enter the version history
> that means these descriptions need to integrate some of the text from
> what is currently PATCH 0/2.
> 
> I would expect this to be more like. It is basically joining together
> text from PATCH 0 and PATCH 1 (I also switched to plural form for SYNC
> bits... the code in the driver has mask generation based on the number
> of strings, is that right?):
Sorry for the trouble. Yes, you are correct. The mask generation is
based on the number of strings defined in the device tree and only those
strings are enabled. However, there is no issue if the SYNC bits of all
the strings are cleared/set. The SYNC takes place only for enabled 
strings.

> ~~~
> Currently, for WLED5, the FSC (Full scale current) setting is not
> updated properly due to driver toggling the wrong register after an FSC
> update.
> 
> On WLED5 we should only toggle the MOD_SYNC bit after a brightness
> update. For an FSC update we need to toggle the SYNC bits instead.
> 
> Fix it by adopting the common wled3_sync_toggle() for WLED5 and
> introducing new code to the brightness update path to
> compensate.
> ~~~
> I will update the Documentation/patch description clearly
as suggested.
> 
> Daniel.
> 
> 
> 
>> 
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>>  drivers/video/backlight/qcom-wled.c | 25 +++++++++++++++++++------
>>  1 file changed, 19 insertions(+), 6 deletions(-)
>> 
>> diff --git a/drivers/video/backlight/qcom-wled.c 
>> b/drivers/video/backlight/qcom-wled.c
>> index 3bc7800..aef52b9 100644
>> --- a/drivers/video/backlight/qcom-wled.c
>> +++ b/drivers/video/backlight/qcom-wled.c
>> @@ -348,7 +348,7 @@ static int wled3_sync_toggle(struct wled *wled)
>>  	return rc;
>>  }
>> 
>> -static int wled5_sync_toggle(struct wled *wled)
>> +static int wled5_mod_sync_toggle(struct wled *wled)
>>  {
>>  	int rc;
>>  	u8 val;
>> @@ -445,10 +445,23 @@ static int wled_update_status(struct 
>> backlight_device *bl)
>>  			goto unlock_mutex;
>>  		}
>> 
>> -		rc = wled->wled_sync_toggle(wled);
>> -		if (rc < 0) {
>> -			dev_err(wled->dev, "wled sync failed rc:%d\n", rc);
>> -			goto unlock_mutex;
>> +		if (wled->version < 5) {
>> +			rc = wled->wled_sync_toggle(wled);
>> +			if (rc < 0) {
>> +				dev_err(wled->dev, "wled sync failed rc:%d\n", rc);
>> +				goto unlock_mutex;
>> +			}
>> +		} else {
>> +			/*
>> +			 * For WLED5 toggling the MOD_SYNC_BIT updates the
>> +			 * brightness
>> +			 */
>> +			rc = wled5_mod_sync_toggle(wled);
>> +			if (rc < 0) {
>> +				dev_err(wled->dev, "wled mod sync failed rc:%d\n",
>> +					rc);
>> +				goto unlock_mutex;
>> +			}
>>  		}
>>  	}
>> 
>> @@ -1459,7 +1472,7 @@ static int wled_configure(struct wled *wled)
>>  		size = ARRAY_SIZE(wled5_opts);
>>  		*cfg = wled5_config_defaults;
>>  		wled->wled_set_brightness = wled5_set_brightness;
>> -		wled->wled_sync_toggle = wled5_sync_toggle;
>> +		wled->wled_sync_toggle = wled3_sync_toggle;
>>  		wled->wled_cabc_config = wled5_cabc_config;
>>  		wled->wled_ovp_delay = wled5_ovp_delay;
>>  		wled->wled_auto_detection_required =
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>>  a Linux Foundation Collaborative Project
>> 

  reply	other threads:[~2021-02-26  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1614138648-2963-1-git-send-email-kgunda@codeaurora.org>
2021-02-24  3:50 ` [PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5 Kiran Gunda
2021-02-24 11:15   ` Daniel Thompson
2021-02-26  6:31     ` kgunda [this message]
2021-02-24  3:50 ` [PATCH V1 2/2] backlight: qcom-wled: Correct the sync_toggle sequence Kiran Gunda
2021-02-24 11:26   ` Daniel Thompson
2021-02-26  6:40     ` kgunda
     [not found] <1613743659-4726-1-git-send-email-kgunda@codeaurora.org>
2021-02-19 14:07 ` [PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5 Kiran Gunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ab55df25e193718c143964dda085d8c@codeaurora.org \
    --to=kgunda@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).