* [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource()
@ 2023-03-08 5:49 Yang Li
2023-03-11 11:57 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-03-08 5:49 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, dri-devel, linux-arm-kernel, linux-kernel, Yang Li
According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/video/fbdev/clps711x-fb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
index 45c75ff01eca..c8bfc608bd9c 100644
--- a/drivers/video/fbdev/clps711x-fb.c
+++ b/drivers/video/fbdev/clps711x-fb.c
@@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device *pdev)
info->fix.mmio_start = res->start;
info->fix.mmio_len = resource_size(res);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- info->screen_base = devm_ioremap_resource(dev, res);
+ info->screen_base = devm_platform_get_and_ioremap_resource(pdev, 1, &res);
if (IS_ERR(info->screen_base)) {
ret = PTR_ERR(info->screen_base);
goto out_fb_release;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource()
2023-03-08 5:49 [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource() Yang Li
@ 2023-03-11 11:57 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2023-03-11 11:57 UTC (permalink / raw)
To: Yang Li; +Cc: linux-fbdev, dri-devel, linux-arm-kernel, linux-kernel
On 3/8/23 06:49, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/clps711x-fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 45c75ff01eca..c8bfc608bd9c 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device *pdev)
> info->fix.mmio_start = res->start;
> info->fix.mmio_len = resource_size(res);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - info->screen_base = devm_ioremap_resource(dev, res);
> + info->screen_base = devm_platform_get_and_ioremap_resource(pdev, 1, &res);
> if (IS_ERR(info->screen_base)) {
> ret = PTR_ERR(info->screen_base);
> goto out_fb_release;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-11 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 5:49 [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-11 11:57 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).