From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E107C19F29 for ; Thu, 28 Jul 2022 14:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231524AbiG1O6b (ORCPT ); Thu, 28 Jul 2022 10:58:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbiG1O61 (ORCPT ); Thu, 28 Jul 2022 10:58:27 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB80B10F3; Thu, 28 Jul 2022 07:58:22 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id mf4so3625945ejc.3; Thu, 28 Jul 2022 07:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tTSXNaw/6JZLwn2P0PGnuQ0WLB4Qu3elZxHzblM8fpU=; b=c1vY1amK3SSb5Sk378Tzj2r3I4dfUYqRyR9XZ9mgTFi9sNzZ23GuRdYijNYiu2eX53 fdsboL/PunLjY5acbyZT/0UEAs/liP15aCEuppzTzwjXwLcsMMG5jUeuBECGpO9nnuUX zXpoNt5vlZnf/4pVrX/7785OC8FVRcxwc0TqmFIbS3cqjDUejPDzp/8oEdwWPd363GbD 0+UmnBhekSdZkddQnF1bwWpmJ7EQAIdBvhqlsKgwl01vpePNvsgcCfHirsTZTdhj3Ady NAWy/pA/+lGohtpaER7TXv1dWORYSk4JeTwNjJx2pzEAFaZ8Yj+Nqowj9RPJbPa7Qiaw HazQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tTSXNaw/6JZLwn2P0PGnuQ0WLB4Qu3elZxHzblM8fpU=; b=s6F7Zmp294qtsm2h1ZfBixL4+zzDGEz1JY0mIur2HPLg1I9onFMreYl0u5Ni1/mdwb nxPa+ejm2WfYkiWg0dnHp9fMhxkcCIpmS4/BpjAfUYp4VYM9rCbijyqYc/qoZuZjUJkP osz/4LxEcv/HJ4Dio13nkCZDWzbp9hWp17UcALJh3Dc17+l/vREGccUB1lTeLXLvS2uy qknuLzb9GXuR5iaQpmpEme0xQ2elVPkxtFrKCISFXbQyKXQ/lyQ+vX3byOzK63hGfWJm E4SgOm+o7DsR+r5hQee9ejn9bcLF1U/6OgvkN5xdCxImVrzZEFLE7JHPMPF8VTMQBLdO 3C+Q== X-Gm-Message-State: AJIora8hC0YE7FZ7FNksR2RxDtVIytXmvgSZ00X2H5f8GLzM1TBdfuNv cUai5ke/A3Wp4emKcO1DHqM= X-Google-Smtp-Source: AGRyM1upxJMWgGwceVicP+qb2cN5gr+enz0dwc0rY8PAmdQ62kOzzpZJEXUWQxNPjQhxhTMGjnE7kA== X-Received: by 2002:a17:907:6818:b0:72b:5bac:c3a3 with SMTP id qz24-20020a170907681800b0072b5bacc3a3mr20623516ejc.139.1659020301357; Thu, 28 Jul 2022 07:58:21 -0700 (PDT) Received: from [0.0.0.0] (tor-exit-60.for-privacy.net. [185.220.101.60]) by smtp.gmail.com with ESMTPSA id cq3-20020a056402220300b0043bc300c499sm827109edb.79.2022.07.28.07.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 07:58:21 -0700 (PDT) Message-ID: <8e694cb6-c3dc-74e3-6804-fc532f108523@gmail.com> Date: Thu, 28 Jul 2022 17:57:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem Content-Language: en-US To: Arnd Bergmann Cc: Linux Kernel Mailing List , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Jonathan Corbet , Ard Biesheuvel , Greg Kroah-Hartman , Jiri Slaby , Helge Deller , "Paul E. McKenney" , Borislav Petkov , Andrew Morton , Kees Cook , Randy Dunlap , Damien Le Moal , Thomas Zimmermann , Javier Martinez Canillas , Michal Suchanek , Andy Shevchenko , Wei Ming Chen , Bartlomiej Zolnierkiewicz , Tony Lindgren , "open list:DOCUMENTATION" , linux-efi , "open list:SERIAL DRIVERS" , Linux Fbdev development list , dri-devel , Rob Herring References: <20220728142824.3836-1-markuss.broks@gmail.com> <20220728142824.3836-3-markuss.broks@gmail.com> From: Markuss Broks In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Arnd, On 7/28/22 17:48, Arnd Bergmann wrote: > On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks wrote: >> >> Add early console support for generic linear framebuffer devices. >> This driver supports probing from cmdline early parameters >> or from the device-tree using information in simple-framebuffer node. >> The EFI functionality should be retained in whole. >> The driver was disabled on ARM because of a bug in early_ioremap >> implementation on ARM. >> >> Signed-off-by: Markuss Broks >> --- >> .../admin-guide/kernel-parameters.txt | 12 +- >> MAINTAINERS | 5 + >> drivers/firmware/efi/Kconfig | 6 +- >> drivers/firmware/efi/Makefile | 1 - >> drivers/firmware/efi/earlycon.c | 246 -------------- >> drivers/video/fbdev/Kconfig | 11 + >> drivers/video/fbdev/Makefile | 1 + >> drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++ > > It looks like this is not actually related to fbdev, and since drivers are > moving from fbdev/simplefb towards drm/simpledrm, maybe it would be > better to put this into either drivers/gpu/drm/tiny/ or possibly > drivers/video/console to let this be used without enabling fbdev? Ideally this shouldn't depend on anything, because it isn't utilizing any of fbdev code and won't be utilizing any of drm/console code. I agree that either of those would be a better place for it, but which one do you think would suit more for this driver? > > Arnd - Markuss