From: Helge Deller <deller@gmx.de>
To: Jani Nikula <jani.nikula@linux.intel.com>,
harperchen <harperchen1110@gmail.com>
Cc: linux-fbdev@vger.kernel.org, javierm@redhat.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
wsa+renesas@sang-engineering.com, tzimmermann@suse.de
Subject: Re: [PATCH] fbdev: tgafb: Fix potential divide by zero
Date: Thu, 9 Mar 2023 09:15:47 +0100 [thread overview]
Message-ID: <92a9d8d4-17e8-6906-7640-e7b82787f74a@gmx.de> (raw)
In-Reply-To: <87cz5ibbsb.fsf@intel.com>
On 3/9/23 08:53, Jani Nikula wrote:
> On Wed, 08 Mar 2023, Helge Deller <deller@gmx.de> wrote:
>> On 3/7/23 14:08, harperchen wrote:
>>> fb_set_var would by called when user invokes ioctl with cmd
>>> FBIOPUT_VSCREENINFO. User-provided data would finally reach
>>> tgafb_check_var. In case var->pixclock is assigned to zero,
>>> divide by zero would occur when checking whether reciprocal
>>> of var->pixclock is too high.
>>>
>>> Similar crashes have happened in other fbdev drivers. There
>>> is no check and modification on var->pixclock along the call
>>> chain to tgafb_check_var. We believe it could also be triggered
>>> in driver tgafb from user site.
>>>
>>> Signed-off-by: harperchen <harperchen1110@gmail.com>
>>
>> Could you provide a real name?
>> Otherwise applied to fbdev git tree.
>
> See commit d4563201f33a ("Documentation: simplify and clarify DCO
> contribution example language").
Nice. Thanks for that link!
Btw, I did applied that patch yesterday to my tree with just the nickname,
but of course I do prefer real names which is why I asked.
Helge
prev parent reply other threads:[~2023-03-09 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 13:08 [PATCH] fbdev: tgafb: Fix potential divide by zero harperchen
2023-03-08 22:05 ` Helge Deller
2023-03-09 6:11 ` Wei Chen
2023-03-09 7:53 ` Jani Nikula
2023-03-09 8:15 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92a9d8d4-17e8-6906-7640-e7b82787f74a@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=harperchen1110@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).