From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B9DC433ED for ; Thu, 8 Apr 2021 21:45:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9DFC610CF for ; Thu, 8 Apr 2021 21:45:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232532AbhDHVps (ORCPT ); Thu, 8 Apr 2021 17:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232488AbhDHVps (ORCPT ); Thu, 8 Apr 2021 17:45:48 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1787AC061761 for ; Thu, 8 Apr 2021 14:45:36 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id b4so6409146lfi.6 for ; Thu, 08 Apr 2021 14:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8MVBTVTbGflc/UsLhIwl2nRzF2EsRH8eZ0QlPXqs5ps=; b=Zk2v3nSMdaCm5adH4aHswvLKgEBKklbkCPH2zPgIVKp64w70n2axR/qGDplIQ0OZ0n HLegwMCSSCAxIt8LPsDPeA7J+lV2LnPtLiSNhLWjp/m3yDKXUPRvs0hxnHugTRrpsB6U uiiThswQsEAPRovlktmLYn49OPrRupsH66VDSzbKlxFr/Wn44w766AsgYLN7vrCHZLyR Uur3yAtqGAhF8O/MxSPYa1P5Yxp+6YntEF7We62ytpY0VEX1MNQUtmH/O+iMLbWa2H+y yeUIQCjgCMD2v6FVfHm061JaiZ7pmmjnI2REqJ3G0vMQF8z8vVWj0AbKZlNKPI0hg/VG eF2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8MVBTVTbGflc/UsLhIwl2nRzF2EsRH8eZ0QlPXqs5ps=; b=lFd9f1/37NKUTN6rqVNJHuFJzpIJjQ45VLb5ZxfIVBsras10r+us2u5XNaRQu7+d7p bCVBIG0ALqgJcN54XyOQE+obfl7I+oIY64RR4TYkYPcxpBDmV8DhK61UlA1Btc02gIie DmFd6q5qdLoOIQ+qIdlvEGhPCNh3Y+sRweuZPklBEPdWdRe7Te9Nai3gKpdNBLGRReQ1 D4XLR5MVaEmCTlbixYR4Iha4ly6j2064sJf1GIQz/Q1UJ9X/KqtgueTcMg1bv5lJos8f 0Nub0lawR4FhINUfEOrxPS1FsQAQkZs70eUUS2gW1a3fALzlSOe+X9bJUR6chiv3Nf1Q Z2sA== X-Gm-Message-State: AOAM5335+rr3H4j7+zr1Ty98mZ75hMDZ2H/aJnEy9HkP3Tz8qDmBQPOd 8V4z61x6Caqu1BHLoZbU9VK+FxAPheTeMcCajP7BuA== X-Google-Smtp-Source: ABdhPJwOR1qaBP0hkaYoeDA9UZM861Q2LgMU2bP4wenXDG9wfbiuruw1rThn3wnUQVO3cDtDB82sQHZzPUH6KOtdfMo= X-Received: by 2002:a19:ef18:: with SMTP id n24mr8062945lfh.291.1617918334556; Thu, 08 Apr 2021 14:45:34 -0700 (PDT) MIME-Version: 1.0 References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> <2ef3b65c-c0ef-7bbe-0e05-39ee8f2bae48@redhat.com> In-Reply-To: <2ef3b65c-c0ef-7bbe-0e05-39ee8f2bae48@redhat.com> From: Linus Walleij Date: Thu, 8 Apr 2021 23:45:23 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: David Hildenbrand Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Thu, Apr 8, 2021 at 6:44 PM David Hildenbrand wrote: > > drivers/gpu/drm/mcde/Kconfig > > drivers/gpu/drm/pl111/Kconfig > > drivers/gpu/drm/tve200/Kconfig > > I was assuming these are "real" dependencies. Will it also work without > DMA_CMA? It will mostly work but that is only because the reservations are mostly contiguous anyway because they are done early and are small. The hardware requires contiguous buffers in all three cases. I'm not sure I always got it right. > > certainly needs this as well, and pretty much anything that is > > selecting DRM_KMS_CMA_HELPER or > > DRM_GEM_CMA_HELPER "wants" DMA_CMA. > > "wants" as in "desires to use but can life without" or "wants" as in > "really needs it". ? I don't know the exact semantics of using DRM_KMS_CMA* without actually using DMA_CMA. I suspect small allocations will be contiguous and big allocations will start to fragment? but it's just my guess. I guess "really need it"? Yours, Linus Walleij