Linux-fbdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] fbdev/sh_mobile: Drop unused include
@ 2020-10-30  0:28 Linus Walleij
  2020-10-30  7:41 ` Geert Uytterhoeven
  2020-11-01  9:36 ` Sam Ravnborg
  0 siblings, 2 replies; 4+ messages in thread
From: Linus Walleij @ 2020-10-30  0:28 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz, linux-fbdev, dri-devel
  Cc: Linus Walleij, Magnus Damm, Geert Uytterhoeven, linux-renesas-soc

The driver includes <linux/gpio.h> but doesn't use any symbols
from this file.

Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/video/fbdev/sh_mobile_lcdcfb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
index c1043420dbd3..027c74d7c010 100644
--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
+++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
@@ -16,7 +16,6 @@
 #include <linux/dma-mapping.h>
 #include <linux/delay.h>
 #include <linux/fbcon.h>
-#include <linux/gpio.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/ioctl.h>
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fbdev/sh_mobile: Drop unused include
  2020-10-30  0:28 [PATCH] fbdev/sh_mobile: Drop unused include Linus Walleij
@ 2020-10-30  7:41 ` Geert Uytterhoeven
  2020-11-01  9:36 ` Sam Ravnborg
  1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-10-30  7:41 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Bartlomiej Zolnierkiewicz, Linux Fbdev development list,
	DRI Development, Magnus Damm, Linux-Renesas

On Fri, Oct 30, 2020 at 1:30 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> The driver includes <linux/gpio.h> but doesn't use any symbols
> from this file.
>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
on r8a77440/armadillo, where this is the last piece of non-DT support.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fbdev/sh_mobile: Drop unused include
  2020-10-30  0:28 [PATCH] fbdev/sh_mobile: Drop unused include Linus Walleij
  2020-10-30  7:41 ` Geert Uytterhoeven
@ 2020-11-01  9:36 ` Sam Ravnborg
  2020-11-06 13:45   ` Linus Walleij
  1 sibling, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2020-11-01  9:36 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Bartlomiej Zolnierkiewicz, linux-fbdev, dri-devel,
	linux-renesas-soc, Magnus Damm, Geert Uytterhoeven

Hi Linus,

On Fri, Oct 30, 2020 at 01:28:50AM +0100, Linus Walleij wrote:
> The driver includes <linux/gpio.h> but doesn't use any symbols
> from this file.
> 
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Thanks, I went ahead and applied this to drm-misc-next.
And then I remembered you have commit right too :-(

	Sam

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fbdev/sh_mobile: Drop unused include
  2020-11-01  9:36 ` Sam Ravnborg
@ 2020-11-06 13:45   ` Linus Walleij
  0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-11-06 13:45 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Bartlomiej Zolnierkiewicz, Linux Fbdev development list,
	open list:DRM PANEL DRIVERS, Linux-Renesas, Magnus Damm,
	Geert Uytterhoeven

On Sun, Nov 1, 2020 at 10:36 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> On Fri, Oct 30, 2020 at 01:28:50AM +0100, Linus Walleij wrote:
> > The driver includes <linux/gpio.h> but doesn't use any symbols
> > from this file.
> >
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: linux-renesas-soc@vger.kernel.org
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Thanks, I went ahead and applied this to drm-misc-next.
> And then I remembered you have commit right too :-(

Thanks! It is always better if someone else does it anyways!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30  0:28 [PATCH] fbdev/sh_mobile: Drop unused include Linus Walleij
2020-10-30  7:41 ` Geert Uytterhoeven
2020-11-01  9:36 ` Sam Ravnborg
2020-11-06 13:45   ` Linus Walleij

Linux-fbdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fbdev/0 linux-fbdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fbdev linux-fbdev/ https://lore.kernel.org/linux-fbdev \
		linux-fbdev@vger.kernel.org
	public-inbox-index linux-fbdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fbdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git