linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ChiYuan Huang <u0084500@gmail.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
	jingoohan1@gmail.com, b.zolnierkie@samsung.com,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>,
	ChiYuan Huang <cy_huang@richtek.com>
Subject: Re: [PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight
Date: Mon, 29 Mar 2021 21:46:48 +0800	[thread overview]
Message-ID: <CADiBU3-2LvLzUZA08EKvzZ7qG8xKPbzbbFzTE3H-Z_8DMP=5OA@mail.gmail.com> (raw)
In-Reply-To: <20210329102631.sh5ttefjvfsfg6tk@maple.lan>

Hi, Daniel:

Daniel Thompson <daniel.thompson@linaro.org> 於 2021年3月29日 週一 下午6:26寫道:
>
> On Sun, Mar 28, 2021 at 11:24:19PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Adds support for Richtek RT4831 backlight.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > since v6
> > - Fix Kconfig typo.
> > - Remove internal mutex lock.
> > - Add the prefix for max brightness.
> > - rename init_device_properties to parse_backlight_properties.
> > - Remove some warning message if default value is adopted.
> > - Add backlight property scale to LINEAR mapping.
> > - Fix regmap get to check NULL not IS_ERR.
> > ---
> >  drivers/video/backlight/Kconfig            |   8 ++
> >  drivers/video/backlight/Makefile           |   1 +
> >  drivers/video/backlight/rt4831-backlight.c | 203 +++++++++++++++++++++++++++++
> >  3 files changed, 212 insertions(+)
> >  create mode 100644 drivers/video/backlight/rt4831-backlight.c
> >
> > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> > index d83c87b..de96441 100644
> > --- a/drivers/video/backlight/Kconfig
> > +++ b/drivers/video/backlight/Kconfig
> > @@ -289,6 +289,14 @@ config BACKLIGHT_QCOM_WLED
> >         If you have the Qualcomm PMIC, say Y to enable a driver for the
> >         WLED block. Currently it supports PM8941 and PMI8998.
> >
> > +config BACKLIGHT_RT4831
> > +     tristate "Richtek RT4831 Backlight Driver"
> > +     depends on MFD_RT4831
> > +     help
> > +       This enables support for Richtek RT4831 Backlight driver.
> > +       It's common used to drive the display WLED. There're four channels
>
> Nitpicking but I was expecting the original typo be converted to
> "commonly".
>
OK, I'll correct this typo in v7 next.
And will merge the reviewed-by line.
Thx.
>
> With that addressed:
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>
> Daniel.

  reply	other threads:[~2021-03-29 13:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 15:24 [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831 cy_huang
2021-03-28 15:24 ` [PATCH v6 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight cy_huang
2021-03-29 10:28   ` Daniel Thompson
2021-03-28 15:24 ` [PATCH v6 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831 cy_huang
2021-03-28 15:24 ` [PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight cy_huang
2021-03-29 10:26   ` Daniel Thompson
2021-03-29 13:46     ` ChiYuan Huang [this message]
2021-04-19  5:57 ` [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831 ChiYuan Huang
2021-04-19  7:22   ` Lee Jones
2021-04-19  7:23     ` Lee Jones
2021-04-19  7:24       ` Lee Jones
2021-04-19  9:55         ` ChiYuan Huang
2021-04-23  0:58           ` ChiYuan Huang
2021-04-23  8:27             ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADiBU3-2LvLzUZA08EKvzZ7qG8xKPbzbbFzTE3H-Z_8DMP=5OA@mail.gmail.com' \
    --to=u0084500@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).