From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C141FC43460 for ; Tue, 13 Apr 2021 18:37:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A23FD613C5 for ; Tue, 13 Apr 2021 18:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347934AbhDMSiD (ORCPT ); Tue, 13 Apr 2021 14:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbhDMSiD (ORCPT ); Tue, 13 Apr 2021 14:38:03 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8094C061756 for ; Tue, 13 Apr 2021 11:37:40 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id c16so17986290oib.3 for ; Tue, 13 Apr 2021 11:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9l7MhNlE9zmt6nhNqqiUgq+wfQLEas5zTZd2Qi3n29c=; b=QOsR2qML+66/IL/2QygasVpniZsHI8EFVaq3gMigiAz1z0nR9iUZDxl2m8vc9Uas8t UbUicdnCbJI38veDYp8o7bnzx7trAahcwjmWnNJVBr58E7Z3wG0AFiuOOdaOa/bhmAPM UC7Pc5mHm/MRYrAatiU0fjhGoaF6Ez1LMNg6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9l7MhNlE9zmt6nhNqqiUgq+wfQLEas5zTZd2Qi3n29c=; b=PRe8ZWwoi6xb1WyM/xy6ZbMegMAA2+TAxELXOkFNvPR7FE2Q6ztubPurA5Vj+b9Aq0 AvBjoLSfMWKwAP2eLH75tUebD52+YmN0dK6lDJVrHIZk3kmEaJXToDNJfccggedKNULT 01vc07nTPUPNuRReRwYdqR05Gg0RZ8UCBixO5qWC2Ol0RIcN9zh0WmjCvUiY1jx0eFMa SmJJZHjVCpX8mJP2YkViEp+elyK70CWxMuHvXMyovOAFFzTC939R2ExTKtVedGmC72dD Qu4Im1vTPpkaudPlBTjblm+RsI881EHF7SwWLmiVrzqBPy3vy5FqA4zLMMzgoYErSSFX pceQ== X-Gm-Message-State: AOAM530JBXXhrk6ZoyTc38fU8Blo7PPZupjUaLxlllYyqB3CWPC619B7 kOaI9gTAjMsvUoXa1dNojO3FviypXrLPKrDbO7t/Wg== X-Google-Smtp-Source: ABdhPJzt3kTr/mnJ3swKnUlL5iVJ4GtE2T/oWlZHUL1YEPuogvLtGB1kNXErK0jci66Ehs3+KW5l0HK9ayVogLDiydM= X-Received: by 2002:aca:4188:: with SMTP id o130mr964224oia.101.1618339060149; Tue, 13 Apr 2021 11:37:40 -0700 (PDT) MIME-Version: 1.0 References: <20210413170508.968148-1-kai.heng.feng@canonical.com> In-Reply-To: From: Daniel Vetter Date: Tue, 13 Apr 2021 20:37:29 +0200 Message-ID: Subject: Re: [PATCH] efifb: Check efifb_pci_dev before using it To: Alex Deucher Cc: Kai-Heng Feng , "open list:EFIFB FRAMEBUFFER DRIVER" , open list , "open list:FRAMEBUFFER LAYER" , pjones@redhat.com, Thomas Zimmermann , Alex Deucher Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher wrote: > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng > wrote: > > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not > > a PCI device. > > > > So make sure efifb_pci_dev is found before using it. > > > > Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0") > > BugLink: https://bugs.launchpad.net/bugs/1922403 > > Signed-off-by: Kai-Heng Feng > > Reviewed-by: Alex Deucher fbdev is in drm-misc, so maybe you can push this one too? -Daniel > > > --- > > drivers/video/fbdev/efifb.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > > index f58a545b3bf3..8ea8f079cde2 100644 > > --- a/drivers/video/fbdev/efifb.c > > +++ b/drivers/video/fbdev/efifb.c > > @@ -575,7 +575,8 @@ static int efifb_probe(struct platform_device *dev) > > goto err_fb_dealoc; > > } > > fb_info(info, "%s frame buffer device\n", info->fix.id); > > - pm_runtime_get_sync(&efifb_pci_dev->dev); > > + if (efifb_pci_dev) > > + pm_runtime_get_sync(&efifb_pci_dev->dev); > > return 0; > > > > err_fb_dealoc: > > @@ -602,7 +603,8 @@ static int efifb_remove(struct platform_device *pdev) > > unregister_framebuffer(info); > > sysfs_remove_groups(&pdev->dev.kobj, efifb_groups); > > framebuffer_release(info); > > - pm_runtime_put(&efifb_pci_dev->dev); > > + if (efifb_pci_dev) > > + pm_runtime_put(&efifb_pci_dev->dev); > > > > return 0; > > } > > -- > > 2.30.2 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch