From: Zheyu Ma <zheyuma97@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: adaplas@gmail.com, linux-fbdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] add checks against divide error
Date: Mon, 26 Jul 2021 17:42:39 +0800 [thread overview]
Message-ID: <CAMhUBj=hkmDjo4MseGsYRwwofQdeUm4HChsRWdwE0XF4WY9x9Q@mail.gmail.com> (raw)
In-Reply-To: <YP3HI0rm9jVwm3ma@ravnborg.org>
On Mon, Jul 26, 2021 at 4:18 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Zheyu,
>
> On Sun, Jul 25, 2021 at 02:10:51AM +0000, Zheyu Ma wrote:
> > Zheyu Ma (3):
> > video: fbdev: kyro: add a check against divide error
> > video: fbdev: riva: add a check against divide error
> > video: fbdev: asiliantfb: add a check against divide error
>
> I would prefer something a bit more descriptive - like:
>
> video: fbdev: <driver>: Error out if pixclk equals zero
>
> Please respin so we have something like the above.
> I looked briefly at the patches, they looked fine.
Thanks for your valuable comments, I will re-edit the commit log and
send the patches.
Regards,
Zheyu Ma
prev parent reply other threads:[~2021-07-26 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 2:10 [PATCH 0/3] add checks against divide error Zheyu Ma
2021-07-25 2:10 ` [PATCH 1/3] video: fbdev: kyro: add a check " Zheyu Ma
2021-07-25 2:10 ` [PATCH 2/3] video: fbdev: riva: " Zheyu Ma
2021-07-25 2:10 ` [PATCH 3/3] video: fbdev: asiliantfb: " Zheyu Ma
[not found] ` <YP3HI0rm9jVwm3ma@ravnborg.org>
2021-07-26 9:42 ` Zheyu Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhUBj=hkmDjo4MseGsYRwwofQdeUm4HChsRWdwE0XF4WY9x9Q@mail.gmail.com' \
--to=zheyuma97@gmail.com \
--cc=adaplas@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).