* [PATCH] fbdev: aty: SPARC64 requires FB_ATY_CT
@ 2020-11-26 0:39 Randy Dunlap
2020-11-26 8:29 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-11-26 0:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, David S. Miller, sparclinux, Tomi Valkeinen,
dri-devel, linux-fbdev, Daniel Vetter, David Airlie,
Bartlomiej Zolnierkiewicz
It looks like SPARC64 requires FB_ATY_CT to build without errors,
so adjust the Kconfig entry of FB_ATY_CT so that it is always 'y'
for SPARC64 && PCI by disabling the prompt for SPARC64 && PCI.
As it currently is, FB_ATY_CT can be disabled, resulting in build
errors:
ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined!
ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined!
Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/video/fbdev/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20201124.orig/drivers/video/fbdev/Kconfig
+++ linux-next-20201124/drivers/video/fbdev/Kconfig
@@ -1277,7 +1277,7 @@ config FB_ATY
module will be called atyfb.
config FB_ATY_CT
- bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support"
+ bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support" if !(SPARC64 && PCI)
depends on PCI && FB_ATY
default y if SPARC64 && PCI
help
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev: aty: SPARC64 requires FB_ATY_CT
2020-11-26 0:39 [PATCH] fbdev: aty: SPARC64 requires FB_ATY_CT Randy Dunlap
@ 2020-11-26 8:29 ` Geert Uytterhoeven
2020-11-26 16:33 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-11-26 8:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, David S. Miller, sparclinux,
Tomi Valkeinen, DRI Development, Linux Fbdev development list,
Daniel Vetter, David Airlie, Bartlomiej Zolnierkiewicz
Hi Randy,
On Thu, Nov 26, 2020 at 1:40 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> It looks like SPARC64 requires FB_ATY_CT to build without errors,
> so adjust the Kconfig entry of FB_ATY_CT so that it is always 'y'
> for SPARC64 && PCI by disabling the prompt for SPARC64 && PCI.
>
> As it currently is, FB_ATY_CT can be disabled, resulting in build
> errors:
>
> ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined!
> ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined!
>
> Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks for your patch!
> --- linux-next-20201124.orig/drivers/video/fbdev/Kconfig
> +++ linux-next-20201124/drivers/video/fbdev/Kconfig
> @@ -1277,7 +1277,7 @@ config FB_ATY
> module will be called atyfb.
>
> config FB_ATY_CT
> - bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support"
> + bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support" if !(SPARC64 && PCI)
> depends on PCI && FB_ATY
> default y if SPARC64 && PCI
> help
What about letting FB_ATY select FB_ATY_CT if SPARC64 && PCI, and
dropping the "default y"-line, instead?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev: aty: SPARC64 requires FB_ATY_CT
2020-11-26 8:29 ` Geert Uytterhoeven
@ 2020-11-26 16:33 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-11-26 16:33 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux Kernel Mailing List, David S. Miller, sparclinux,
Tomi Valkeinen, DRI Development, Linux Fbdev development list,
Daniel Vetter, David Airlie, Bartlomiej Zolnierkiewicz
On 11/26/20 12:29 AM, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Thu, Nov 26, 2020 at 1:40 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> It looks like SPARC64 requires FB_ATY_CT to build without errors,
>> so adjust the Kconfig entry of FB_ATY_CT so that it is always 'y'
>> for SPARC64 && PCI by disabling the prompt for SPARC64 && PCI.
>>
>> As it currently is, FB_ATY_CT can be disabled, resulting in build
>> errors:
>>
>> ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined!
>> ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined!
>>
>> Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks for your patch!
>
>> --- linux-next-20201124.orig/drivers/video/fbdev/Kconfig
>> +++ linux-next-20201124/drivers/video/fbdev/Kconfig
>> @@ -1277,7 +1277,7 @@ config FB_ATY
>> module will be called atyfb.
>>
>> config FB_ATY_CT
>> - bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support"
>> + bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support" if !(SPARC64 && PCI)
>> depends on PCI && FB_ATY
>> default y if SPARC64 && PCI
>> help
>
> What about letting FB_ATY select FB_ATY_CT if SPARC64 && PCI, and
> dropping the "default y"-line, instead?
Sure, I'll try it that way and repost.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-26 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 0:39 [PATCH] fbdev: aty: SPARC64 requires FB_ATY_CT Randy Dunlap
2020-11-26 8:29 ` Geert Uytterhoeven
2020-11-26 16:33 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).