From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78428C6FA92 for ; Fri, 23 Sep 2022 21:34:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbiIWVeW (ORCPT ); Fri, 23 Sep 2022 17:34:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbiIWVeV (ORCPT ); Fri, 23 Sep 2022 17:34:21 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F88274CC1; Fri, 23 Sep 2022 14:34:20 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id y8so1830539edc.10; Fri, 23 Sep 2022 14:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=2tSqnggIyDo6YUr0zNltSFoKVKbExYQv0L5PsQaqx/s=; b=mC5OTEroAwnh1aV0/k1oPe+NXV0TA7Ze+A1xSqjAYtWFHQmQllTO2D5NFTgRNAaYmT 9ftX5WSLtzU2ypfDMT3O8sHcHAnbhOQyP3iw/qBmEo1MS7KrHK9T7qMSNgKzSJ+gKYID /abixiX9djqlc0Y/J/wim5USaRy8aF+H2vHddS2/BtkRSL/9hE50+MF2PbOdi3Sk2Gl6 VosQoBRGmWXFe5bsDbIbt+mPWxWzs9fsS3VkuvMuKTsQce3IGe9Tc+oS/HXH/f+GD3ev uHxxaisRU0SVBPc0aV+ppRW6J8ERcyNX4rsfpw6JIQ1m3AX4/2lvWnFKGIrpL0hEOzl5 cXlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2tSqnggIyDo6YUr0zNltSFoKVKbExYQv0L5PsQaqx/s=; b=dyMjkE7b/TvmkmZl4axMAolpsFsoiL3ibg5RNQzAARoTsZhPA6rX96M+GJtt+mYSgr DGcuPNeaMApNymSNCXnB3AlXVz3f5u2zniamtO+NhxJwjdPK1sFj4TaE6FCvHAru5jiZ +DE/vtUyCW9LDV1i8bUqn/sCK3d0W8cGLQ0btzsf5jUOSpHPE01n8ooRT8d/CDpX/Uro P09eoV5ulAoNT+5SHngJzuOTdYuL2Y3ne22JboNk8m/YwEVVnGTzS2l2i7zTkdrlsr/z /XcSGVO4hRPa6nmr29WdqptfgCVcYDtjJ/Eo2KdVUgrL8Thy5Eg7k7CFZGubhh89JTRz rCLA== X-Gm-Message-State: ACrzQf3iabMzNgr3frTTu6vgCeoH6qEtYwHqqz/UCTrxkHr6Sp+m3I2k dTFVpHipqawoSsYyndYwo67lmXKTPIRFH53uJOk= X-Google-Smtp-Source: AMsMyM5IZsfJ8dcFfC0J6aK5kWjLl/L84uf2axz39u9HVDC/sm5vNCQLHxNNHmrmfV4MxviVVR/a5HiZQAJ2yKDCUpw= X-Received: by 2002:a05:6402:1e8c:b0:44f:f70:e75e with SMTP id f12-20020a0564021e8c00b0044f0f70e75emr10298957edf.405.1663968858816; Fri, 23 Sep 2022 14:34:18 -0700 (PDT) MIME-Version: 1.0 References: <20220830034042.9354-2-peterwu.pub@gmail.com> <20220830034042.9354-10-peterwu.pub@gmail.com> In-Reply-To: From: Han Jingoo Date: Fri, 23 Sep 2022 14:34:07 -0700 Message-ID: Subject: Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support To: Andy Shevchenko , torvalds@linux-foundation.org, Andrew Morton , Joe Perches , Julia.Lawall@inria.fr, krzysztof.kozlowski@linaro.org Cc: ChiaEn Wu , lee@kernel.org, Daniel Thompson , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Jonathan Cameron , Lars-Peter Clausen , Helge Deller , Mark Brown , mazziesaccount@gmail.com, andriy.shevchenko@linux.intel.com, ChiaEn Wu , Alice Chen , ChiYuan Huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, Sep 21, 2022 Andy Shevchenko wrote: > > On Wed, Sep 21, 2022 at 4:48 AM ChiaEn Wu wrote: > > On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo wrote: > > > On Mon, Aug 29, 2022 ChiaEn Wu wrote: > > > > > +#define MT6370_ITORCH_MIN_uA 25000 > > > > +#define MT6370_ITORCH_STEP_uA 12500 > > > > +#define MT6370_ITORCH_MAX_uA 400000 > > > > +#define MT6370_ITORCH_DOUBLE_MAX_uA 800000 > > > > +#define MT6370_ISTRB_MIN_uA 50000 > > > > +#define MT6370_ISTRB_STEP_uA 12500 > > > > +#define MT6370_ISTRB_MAX_uA 1500000 > > > > +#define MT6370_ISTRB_DOUBLE_MAX_uA 3000000 > > > > > > Use upper letters as below: > > For microseconds (and other -seconds) the common practice (I assume > historically) is to use upper letters, indeed. But for current it's > more natural to use small letters for unit multiplier as it's easier > to read and understand. (CC'ed Linus Torvalds, Andrew Morton, Joe Perches, Julia Lawall, Krzysztof Kozlowski,) Yep, it is common practice. Long time ago, I met the same problem on how to present micro-ampere: visibility vs coding practice. At that time, I followed the coding practice. So, was there anyone who rejected this decision to mix upper and lower letters when you gave your comment last July? If there is no objection, or most of maintainers and long-term contributors agree with that, I am ok with that. To Tovalds, Andrew, Joe, Julia, Krzysztof, I just need your feedback on coding styles. Are you ok with mixing upper and lower letters for visibility to present micro-seconds or micro-ampere? Andy (one of very-active contributors) gives his opinion that mixing upper and lower letters can be acceptable. I remain neutral on this coding style issue. e.g., #define MT6370_ITORCH_DOUBLE_MAX_uA 800000 Thank you. Best regards, Jingoo Han > > > > #define MT6370_ITORCH_MIN_UA 25000 > > > #define MT6370_ITORCH_STEP_UA 12500 > > > #define MT6370_ITORCH_MAX_UA 400000 > > > #define MT6370_ITORCH_DOUBLE_MAX_UA 800000 > > > #define MT6370_ISTRB_MIN_UA 50000 > > > #define MT6370_ISTRB_STEP_UA 12500 > > > #define MT6370_ISTRB_MAX_UA 1500000 > > > #define MT6370_ISTRB_DOUBLE_MAX_UA 3000000 > > > > > > > +#define MT6370_STRBTO_MIN_US 64000 > > > > +#define MT6370_STRBTO_STEP_US 32000 > > > > +#define MT6370_STRBTO_MAX_US 2432000 > > > > Hi Jingoo, > > > > This coding style is in accordance with Andy's opinion in this mail: > > https://lore.kernel.org/linux-arm-kernel/CAHp75Vciq4M4kVrabNV9vTLLcd1vR=bMe8JLEdAF9MkRTpcB5g@mail.gmail.com/ > > True. > > -- > With Best Regards, > Andy Shevchenko