From: "tcs_kernel(腾讯云内核开发者)" <tcs_kernel@tencent.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"yepeilin.cs@gmail.com" <yepeilin.cs@gmail.com>,
"penguin-kernel@I-love.SAKURA.ne.jp"
<penguin-kernel@I-love.SAKURA.ne.jp>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"george.kennedy@oracle.com" <george.kennedy@oracle.com>,
"ducheng2@gmail.com" <ducheng2@gmail.com>,
"sam@ravnborg.org" <sam@ravnborg.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] fbcon: Out-Of-Bounds write in sys_imageblit, add range check
Date: Mon, 26 Jul 2021 11:32:37 +0000 [thread overview]
Message-ID: <D5DF8A1C-5FA2-426B-AAB4-3199AEA0A02E@tencent.com> (raw)
yres and vyres can be controlled by user mode paramaters, and cause p->vrows to become a negative value. While this value be passed to real_y function, the ypos will be out of screen range.
This is an out-of-bounds write bug.
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 22bb3892f6bd..0970de46782f 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1956,11 +1956,12 @@ static void updatescrollmode(struct fbcon_display *p,
int yres = FBCON_SWAP(ops->rotate, info->var.yres, info->var.xres);
int vyres = FBCON_SWAP(ops->rotate, info->var.yres_virtual,
info->var.xres_virtual);
+ int rows = vc->vc_rows;
p->vrows = vyres/fh;
- if (yres > (fh * (vc->vc_rows + 1)))
- p->vrows -= (yres - (fh * vc->vc_rows)) / fh;
- if ((yres % fh) && (vyres % fh < yres % fh))
+ if ((yres > (fh * (rows + 1))) && (vyres >= (yres - (fh * rows))) && p->vrows)
+ p->vrows -= (yres - (fh * rows)) / fh;
+ if ((yres % fh) && (vyres % fh < yres % fh) && p->vrows)
p->vrows--;
}
next reply other threads:[~2021-07-26 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 11:32 tcs_kernel(腾讯云内核开发者) [this message]
2021-07-26 13:00 ` [PATCH] fbcon: Out-Of-Bounds write in sys_imageblit, add range check gregkh
[not found] ` <YP68cQ4WVVusCv0N@ravnborg.org>
2021-07-27 1:53 ` [Internet]Re: " tcs_kernel(腾讯云内核开发者)
2021-07-27 5:35 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5DF8A1C-5FA2-426B-AAB4-3199AEA0A02E@tencent.com \
--to=tcs_kernel@tencent.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ducheng2@gmail.com \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).