From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EAEC55ABD for ; Tue, 10 Nov 2020 14:55:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D919207BB for ; Tue, 10 Nov 2020 14:55:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="T9dYpwHe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730666AbgKJOzM (ORCPT ); Tue, 10 Nov 2020 09:55:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:47474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729898AbgKJOzM (ORCPT ); Tue, 10 Nov 2020 09:55:12 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1D4D206F1; Tue, 10 Nov 2020 14:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605020111; bh=0XUvZ13Bc4jYJLdDib1eplfwfa0ykUyr5siWllJlDxI=; h=Date:From:To:Subject:References:In-Reply-To:From; b=T9dYpwHedLN0/xBVzknsB3FFIXxHWXt4zw9Lp4RzO0B12/mwzi32dOQucaEbS98Jq dK7FXr2G9s/qi8MtRJU6sReJvWPi2q+qibIIz4v1piYAYJ0FhMMwSWlmP0jGnopNO3 077kzC1tBirwF+ab2QKVfAzoTVsTBy0FYNQBp0jU= Date: Tue, 10 Nov 2020 15:56:08 +0100 From: Greg Kroah-Hartman To: Peilin Ye , Jiri Slaby , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Nicolas Pitre , "Gustavo A . R . Silva" , Tetsuo Handa , George Kennedy , Nathan Chancellor , Peter Rosin , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 1/2] console: Remove dummy con_font_op() callback implementations Message-ID: References: <20201106105058.GA2801856@kroah.com> <20201110124946.GF401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110124946.GF401619@phenom.ffwll.local> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Nov 10, 2020 at 01:49:46PM +0100, Daniel Vetter wrote: > On Fri, Nov 06, 2020 at 11:50:58AM +0100, Greg Kroah-Hartman wrote: > > On Sat, Oct 31, 2020 at 03:24:41AM -0400, Peilin Ye wrote: > > > `struct console_font` is a UAPI structure, thus ideally should not be > > > used for kernel internal abstraction. Remove some dummy .con_font_set, > > > .con_font_default and .con_font_copy `struct consw` callback > > > implementations, to make it cleaner. > > > > > > Patch "fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()" > > > depends on this patch, so Cc: stable. > > > > > > Cc: stable@vger.kernel.org > > > Suggested-by: Daniel Vetter > > > Signed-off-by: Peilin Ye > > > --- > > > Context: https://lore.kernel.org/lkml/CAKMK7uFY2zv0adjKJ_ORVFT7Zzwn075MaU0rEU7_FuqENLR=UA@mail.gmail.com/ > > > > > > drivers/usb/misc/sisusbvga/sisusb_con.c | 21 --------------------- > > > drivers/video/console/dummycon.c | 20 -------------------- > > > 2 files changed, 41 deletions(-) > > > > Reviewed-by: Greg Kroah-Hartman > > Peilin, can you pls resend this together with all the other pending > patches from you? I think that's better than me trying to cherry-pick the > bits we decided to keep from random places. > > Greg, ok if I just pull these in through drm-misc-next? It's a pretty bad > hairball anyway and that avoids the tree coordination issues. Only thing > that might get in the way is the vt font_copy removal, but that's in -rc3 > so easy to backmerge. Yes please take them all! thanks, greg k-h