From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A65C433DB for ; Wed, 27 Jan 2021 15:39:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64B37207D8 for ; Wed, 27 Jan 2021 15:39:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236261AbhA0PfF (ORCPT ); Wed, 27 Jan 2021 10:35:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:56474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235526AbhA0PDi (ORCPT ); Wed, 27 Jan 2021 10:03:38 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6EFE6207D0; Wed, 27 Jan 2021 15:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611759758; bh=a6xIqEAeZUgI/gWd9D7ZmCNMvsD1qRiSI3ez+rb5KZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=choT2OBuWlOG8kg05sEL8BUB29DZt19Nnaa4X8KY+sYFpz0tJ9bLHBh75H5vRMj4t PTX45RhDBDU/tS+F5IKP8GYt4lpyu0zo5/akga73hKAy8VgP9KyyFDm4dhSmsvZAdR i2woKDQKkpc9YbekJzh8aNTdmXz9JNTnpeFU2AUg= Date: Wed, 27 Jan 2021 16:02:35 +0100 From: Greg KH To: Dan Carpenter Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com, sbrivio@redhat.com, oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joe Perches , carlis , Andy Whitcroft , colin.king@canonical.com, zhangxuezhi1@yulong.com Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect Message-ID: References: <1611754972-151016-1-git-send-email-zhangxuezhi3@gmail.com> <20210127220809.000026fb@gmail.com> <20210127221708.00002568@gmail.com> <20210127144946.GF2696@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127144946.GF2696@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 15:13:05 +0100 > > > Greg KH wrote: > > > > > > > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > > > > On Wed, 27 Jan 2021 14:51:55 +0100 > > > > > Greg KH wrote: > > > > > > > > > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > > > > > From: zhangxuezhi > > > > > > > > > > > > > > For st7789v ic,when we need continuous full screen refresh, it > > > > > > > is best to wait for the TE signal arrive to avoid screen tearing > > > > > > > > > > > > > > Signed-off-by: zhangxuezhi > > > > > > > > > > > > Please slow down and wait at least a day between patch > > > > > > submissions, there is no rush here. > > > > > > > > > > > > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so > > > > > > that you don't have a maintainer asking you about basic problems, > > > > > > like are in this current patch :( > > > > > > > > > > > > thanks, > > > > > > > > > > > > greg k-h > > > > > > > > > > hi, > > > > > This is my first patch contribution to Linux, so some of the rules > > > > > are not very clear .In addition, I can confirm that before sending > > > > > patch, I check it with checkPatch.py every time.Thank you very much > > > > > for your help > > > > > > > > Please read Documentation/SubmittingPatches which has a link to the > > > > checklist and other documentation you should read. > > > > > > > > And I doubt you are running checkpatch on your submission, as there is > > > > obvious coding style issues in it. If so, please provide the output > > > > as it must be broken :( > > > > > > > > thanks, > > > > > > > > greg k-h > > > hi, the patch v11 checkpatch.pl output is below: > > > > > > carlis@bf-rmsz-10:~/work/linux-kernel/linux$ ./scripts/checkpatch.pl > > > 0001-staging-fbtft-add-tearing-signal-detect.patch total: 0 errors, 0 > > > warnings, 0 checks, 176 lines checked > > > > > > 0001-staging-fbtft-add-tearing-signal-detect.patch has no obvious style > > > problems and is ready for submission. > > > > Wow, my apologies! > > > > Andy and Joe, there's something wrong here that is missing the fact that > > a line is being indented with spaces and not tabs in the patch > > at https://lore.kernel.org/r/1611754972-151016-1-git-send-email-zhangxuezhi3@gmail.com > > > > Any ideas what broke? > > > > /*Tearing Effect Line On*/ > > Comments are the exception to the "no spaces at the start of a line" > rule. I was expecting that the kbuild-bot would send a Smatch warning > for inconsistent indenting, but comments are not counted there either. > > I'm sort of surprised that we don't have checkpatch rule about the > missing space characters. It should be: "/* Tearing Effect Line On */". That was going to be my next question, lots of comments added in this patch don't have spaces... thanks, greg k-h