linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Phil Reid" <preid@electromag.com.au>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	"Jan Sebastian Götte" <linux@jaseg.net>,
	"Nishad Kamdar" <nishadkamdar@gmail.com>
Subject: Re: [PATCH v3 1/4] staging: fbtft: Rectify GPIO handling
Date: Mon, 3 May 2021 18:38:00 +0200	[thread overview]
Message-ID: <YJAm6D2LUtVz1YNa@kroah.com> (raw)
In-Reply-To: <20210428130415.55406-2-andriy.shevchenko@linux.intel.com>

On Wed, Apr 28, 2021 at 04:04:12PM +0300, Andy Shevchenko wrote:
> The infamous commit c440eee1a7a1 ("Staging: staging: fbtft: Switch to
> the GPIO descriptor interface") broke GPIO handling completely.
> It has already four commits to rectify and it seems not enough.
> In order to fix the mess here we:
> 
>   1) Set default to "inactive" for all requested pins
> 
>   2) Fix CS#, RD#, and WR# pins polarity since it's active low
>      and GPIO descriptor interface takes it into consideration
>      from the Device Tree or ACPI
> 
>   3) Consolidate chip activation (CS# assertion) under default
>      ->reset() callback
> 
> To summarize the expectations about polarity for GPIOs:
> 
>    RD#			Low
>    WR#			Low
>    CS#			Low
>    RESET#		Low
>    DC or RS		High
>    RW			High
>    Data	0 .. 15		High
> 
> See also Adafruit learning course [1] for the example of the schematics.
> 
> While at it, drop unneeded NULL checks, since GPIO API is tolerant to that.
> 
> [1]: https://learn.adafruit.com/adafruit-2-8-and-3-2-color-tft-touchscreen-breakout-v2/downloads
> 
> Fixes: 92e3e884887c ("Staging: staging: fbtft: Fix GPIO handling")
> Fixes: b918d1c27066 ("Staging: staging: fbtft: Fix reset assertion when using gpio descriptor")
> Fixes: dbc4f989c878 ("Staging: staging: fbtft: Fix probing of gpio descriptor")
> Fixes: c440eee1a7a1 ("Staging: staging: fbtft: Switch to the gpio descriptor interface")

I get the following error when trying to apply this:

	Fixes tag: Fixes: 92e3e884887c ("Staging: staging: fbtft: Fix GPIO handling")
	Has these problem(s):
	        - Subject does not match target commit subject
	          Just use
		                git log -1 --format='Fixes: %h ("%s")'
	Fixes tag: Fixes: b918d1c27066 ("Staging: staging: fbtft: Fix reset assertion when using gpio descriptor")
	Has these problem(s):
	        - Subject does not match target commit subject
	          Just use
		                git log -1 --format='Fixes: %h ("%s")'
	Fixes tag: Fixes: dbc4f989c878 ("Staging: staging: fbtft: Fix probing of gpio descriptor")
	Has these problem(s):
	        - Subject does not match target commit subject
	          Just use
		                git log -1 --format='Fixes: %h ("%s")'
	Fixes tag: Fixes: c440eee1a7a1 ("Staging: staging: fbtft: Switch to the gpio descriptor interface")
	Has these problem(s):
	        - Subject does not match target commit subject
	          Just use
		                git log -1 --format='Fixes: %h ("%s")'

Please fix up for your next version of this series.

thanks,

greg k-h

  reply	other threads:[~2021-05-03 16:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 13:04 [PATCH v3 0/4] staging: fbtft: Fixing GPIO handling issues Andy Shevchenko
2021-04-28 13:04 ` [PATCH v3 1/4] staging: fbtft: Rectify GPIO handling Andy Shevchenko
2021-05-03 16:38   ` Greg Kroah-Hartman [this message]
2021-05-03 17:08     ` Andy Shevchenko
2021-04-28 13:04 ` [PATCH v3 2/4] staging: fbtft: Replace custom ->reset() with generic one Andy Shevchenko
2021-04-28 13:04 ` [PATCH v3 3/4] staging: fbtft: Don't spam logs when probe is deferred Andy Shevchenko
2021-04-29 14:42   ` Dan Carpenter
2021-04-29 15:40     ` Dan Carpenter
2021-04-29 16:56     ` Andy Shevchenko
2021-04-28 13:04 ` [PATCH v3 4/4] staging: fbtft: Update TODO Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJAm6D2LUtVz1YNa@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux@jaseg.net \
    --cc=nishadkamdar@gmail.com \
    --cc=preid@electromag.com.au \
    --subject='Re: [PATCH v3 1/4] staging: fbtft: Rectify GPIO handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).