From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anirudh Rayabharam <mail@anirudhrb.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
kernel test robot <oliver.sang@intel.com>,
stable <stable@vger.kernel.org>,
linux-nvidia@lists.surfsouth.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, igormtorrente@gmail.com,
fero@drama.obuda.kando.hu
Subject: Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
Date: Thu, 20 May 2021 15:58:25 +0200 [thread overview]
Message-ID: <YKZrAVk85IjNYVHs@kroah.com> (raw)
In-Reply-To: <YKZm17dj4R1c2ns/@anirudhrb.com>
On Thu, May 20, 2021 at 07:10:39PM +0530, Anirudh Rayabharam wrote:
> On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> > The return value of hga_card_detect() is not properly handled causing
> > the probe to succeed even though hga_card_detect() failed. Since probe
> > succeeds, hgafb_open() can be called which will end up operating on an
> > unmapped hga_vram. This results in an out-of-bounds access as reported
> > by kernel test robot [1].
> >
> > To fix this, correctly detect failure of hga_card_detect() by checking
> > for a non-zero error code.
> >
> > [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
> >
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
>
> Greg, this is one of the UMN fixes we did. So, do you want to take this
> patch into your tree?
Yes, will queue it up in a few days after Linus takes the current pull
request I sent him for this.
thanks,
greg k-h
prev parent reply other threads:[~2021-05-20 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 19:27 [PATCH] video: hgafb: correctly handle card detect failure during probe Anirudh Rayabharam
2021-05-17 12:27 ` Igor Torrente
2021-05-20 13:40 ` Anirudh Rayabharam
2021-05-20 13:58 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKZrAVk85IjNYVHs@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fero@drama.obuda.kando.hu \
--cc=igormtorrente@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=mail@anirudhrb.com \
--cc=oliver.sang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).