From: Lee Jones <lee.jones@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
stable@vger.kernel.org,
"Meghana Madhyastha" <meghana.madhyastha@gmail.com>,
"Sean Paul" <seanpaul@chromium.org>,
"Thierry Reding" <treding@nvidia.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero
Date: Tue, 21 Sep 2021 14:33:20 +0100 [thread overview]
Message-ID: <YUnfIFllpOMnie4l@google.com> (raw)
In-Reply-To: <072e01b7-8554-de4f-046a-da11af3958d6@denx.de>
On Sat, 11 Sep 2021, Marek Vasut wrote:
> On 7/13/21 9:16 PM, Marek Vasut wrote:
> > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper
> > in backlight.c") says that gpio-backlight uses brightness as power state.
> > This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
> > Correct initial power state handling") and other backlight drivers do not
> > require this workaround. Drop the workaround.
> >
> > This fixes the case where e.g. pwm-backlight can perfectly well be set to
> > brightness 0 on boot in DT, which without this patch leads to the display
> > brightness to be max instead of off.
> >
> > Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c")
> > Acked-by: Noralf Trønnes <noralf@tronnes.org>
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: <stable@vger.kernel.org> # 5.4+
> > Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> > Cc: Noralf Trønnes <noralf@tronnes.org>
> > Cc: Sean Paul <seanpaul@chromium.org>
> > Cc: Thierry Reding <treding@nvidia.com>
> > ---
> > V2: Add AB/RB, CC stable
> > ---
> > drivers/video/backlight/backlight.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> > index 537fe1b376ad7..fc990e576340b 100644
> > --- a/drivers/video/backlight/backlight.c
> > +++ b/drivers/video/backlight/backlight.c
> > @@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
> > of_node_put(np);
> > if (!bd)
> > return ERR_PTR(-EPROBE_DEFER);
> > - /*
> > - * Note: gpio_backlight uses brightness as
> > - * power state during probe
> > - */
> > - if (!bd->props.brightness)
> > - bd->props.brightness = bd->props.max_brightness;
> > }
> > }
> >
>
> Any news on this ?
>
> Expanding CC list.
Looks like I was left off of the original submission.
I can't apply a quoted patch. Please re-submit.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-09-21 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 19:16 [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero Marek Vasut
2021-09-11 18:40 ` Marek Vasut
2021-09-21 13:33 ` Lee Jones [this message]
2021-09-21 17:31 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUnfIFllpOMnie4l@google.com \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=marex@denx.de \
--cc=meghana.madhyastha@gmail.com \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=stable@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).