From: Lee Jones <lee.jones@linaro.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] backlight: propagate errors from get_brightness()
Date: Thu, 23 Sep 2021 14:43:24 +0100 [thread overview]
Message-ID: <YUyEfDJZT0hr5nI4@google.com> (raw)
In-Reply-To: <4bb3051e-2550-43c3-afed-d4b00850126e@t-8ch.de>
On Thu, 23 Sep 2021, Thomas Weißschuh wrote:
> On 2021-09-23T10:48+0100, Lee Jones wrote:
> > On Tue, 07 Sep 2021, Thomas Weißschuh wrote:
> >
> > > backlight.h documents "struct backlight_ops->get_brightness()" to return
> > > a negative errno on failure.
> > > So far these errors have not been handled in the backlight core.
> > > This leads to negative values being exposed through sysfs although only
> > > positive values are documented to be reported.
> > >
> > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > > ---
> > >
> > > v1: https://lore.kernel.org/dri-devel/20210906215525.15418-1-linux@weissschuh.net/
> > >
> > > v1 -> v2:
> > > * use dev_err() instead of dev_warn() (Daniel Thompson)
> > > * Finish logging format string with newline (Daniel Thompson)
> > > * Log errno via dedicated error pointer format (Daniel Thompson)
> > >
> > > drivers/video/backlight/backlight.c | 22 +++++++++++++++++-----
> > > 1 file changed, 17 insertions(+), 5 deletions(-)
> >
> > Applied, thanks.
>
> Hi Lee,
>
> thanks!
>
> Also I'm sorry about my nagging before.
No worries.
> I was not aware you were on vacation and saw you respond to other mails.
They were in the queue before this one.
I had hundreds of emails to get through on my return!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-09-23 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:47 [PATCH v2] backlight: propagate errors from get_brightness() Thomas Weißschuh
2021-09-07 13:10 ` Daniel Thompson
2021-09-07 14:52 ` Thomas Weißschuh
2021-09-21 14:50 ` Thomas Weißschuh
2021-09-21 14:56 ` Lee Jones
2021-09-23 9:48 ` Lee Jones
2021-09-23 10:49 ` Thomas Weißschuh
2021-09-23 13:43 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUyEfDJZT0hr5nI4@google.com \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).