From: Magnus Damm <magnus.damm@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] video: add sh_mobile_lcdcfb memory resource
Date: Tue, 12 May 2009 20:18:44 +0900 [thread overview]
Message-ID: <aec7e5c30905120418l1c7027e2y1ff8ebf3752f682a@mail.gmail.com> (raw)
In-Reply-To: <20090512105013.GA20500@linux-sh.org>
On Tue, May 12, 2009 at 7:50 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> On Tue, May 12, 2009 at 06:57:45PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@igel.co.jp>
>>
>> This patch adds memory resource support to the LCDC driver.
>> With this applied the physical memory range used for framebuffer
>> data will show up in /proc/iomem together with other SuperH
>> Mobile devices.
>>
>> Signed-off-by: Magnus Damm <damm@igel.co.jp>
>
> Drivers have no place doing this on their own, besides, insert_resource()
> is not available to modules. The platform device code already takes care
> of this, so perhaps I am missing what the point of this change is?
Other SuperH Mobile multimedia blocks like the CEU and VEU/VPU/JPU all
get passed a physically contiguous area of memory as platform data. So
for those blocks the memory range show up in /proc/iomem. For the LCDC
this does not happen today.
Thanks for pointing out the module issue. I guess the proper fix would
be to pass a struct resource with memory to the LCDC driver as well
instead of this patch.
Cheeers,
/ magnus
prev parent reply other threads:[~2009-05-12 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 9:57 [PATCH] video: add sh_mobile_lcdcfb memory resource Magnus Damm
2009-05-12 10:50 ` Paul Mundt
2009-05-12 11:18 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30905120418l1c7027e2y1ff8ebf3752f682a@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).