From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Date: Mon, 22 Mar 2010 08:59:07 +0000 Subject: Re: [PATCH v2 3/6] hid: add backlight support to PicoLCD device Message-Id: List-Id: References: <20100320170014.440959a8@neptune.home> <20100320170619.4ae99546@neptune.home> In-Reply-To: <20100320170619.4ae99546@neptune.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?ISO-8859-15?Q?Bruno_Pr=E9mont?= Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar , Richard Purdie On Sat, 20 Mar 2010, Bruno Prémont wrote: > Add backlight support to PicoLCD device. > > Backlight support depends on backlight class and is only being > compiled if backlight class has been selected. > > Signed-off-by: Bruno Prémont > --- > drivers/hid/Kconfig | 2 +- > drivers/hid/hid-picolcd.c | 134 ++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 134 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index a474bcd..5ec3cb7 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -243,8 +243,8 @@ config HID_PICOLCD > - Keypad > - Switching between Firmware and Flash mode > - Framebuffer for monochrome 256x64 display > + - Backlight control (needs CONFIG_BACKLIGHT_CLASS_DEVICE) Wouldn't it be better to have Kconfig rules actually resolve the dependency? I don't see any issue with HID_PICOLCD directly selecting BACKLIGHT_CLASS_DEVICE. Or you can do a separate sub-option for that, if you really want to avoid the direct dependency of the whole driver. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc.