From: Mikulas Patocka <mpatocka@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
linux-fbdev@vger.kernel.org, geert+renesas@glider.be,
corbet@lwn.net, daniel.vetter@ffwll.ch,
linux-doc@vger.kernel.org, bernie@plugable.com,
dri-devel@lists.freedesktop.org, sam@ravnborg.org
Subject: Re: [PATCH] fbdev: Remove udlfb driver
Date: Tue, 1 Dec 2020 06:26:15 -0500 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.2012010621100.1371@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <20201130210629.GY401619@phenom.ffwll.local>
On Mon, 30 Nov 2020, Daniel Vetter wrote:
> On Mon, Nov 30, 2020 at 01:39:17PM -0500, Mikulas Patocka wrote:
> >
> >
> > On Mon, 30 Nov 2020, Daniel Vetter wrote:
> >
> > > On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote:
> > > >
> > > > The framebuffer driver supports programs running full-screen directly on
> > > > the framebuffer console, such as web browser "links -g", image viewer
> > > > "fbi", postscript+pdf viewer "fbgs", ZX Spectrum emulator "fuse-sdl",
> > > > movie player "mplayer -vo fbdev". The DRM driver doesn't run them.
> > >
> > > Hm this should in general work on drm drivers. Without that it's clear the
> > > switch-over isn't really ready yet.
> >
> > I fixed it with this patch two years ago:
> > https://lists.freedesktop.org/archives/dri-devel/2018-June/179023.html
> >
> > But the patch never went through and the fb_defio feature was removed in
> > the kernel 5.6 (commit d0c4fc5a4814e431c15272935c8dc973c18073aa).
>
> The generic fbdev emulation still has a defio implementation. We could try
> to make it more efficient maybe, but it should be all there. The module
> option disappeared since you now should always get it by default.
Yes, it's there. I've tried to run links on the current DRM UDL driver and
it displays correctly - except, that the page list gets sometimes
corrupted and a crash happens.
> > Without fb_defio, the only other possibility how to update the screen is
> > the ioctl DRM_IOCTL_MODE_DIRTYFB. But this ioctl requires master mode, so
> > user programs like "links -g" can't issue it.
>
> Now I'm confused, I thought you wanted to use fbdev /dev/fb* nodes? Those
> should support defio. And if you want your applications to use drm
> modesetting natively, they have to be drm master anyway. You can't use the
> DIRTYFB ioctl to upload fbdev contents. So I'm a bit confused.
> -Daniel
Yes. I was confused about it too. You can't use DRM ioctls on /dev/fb.
Mikulas
next prev parent reply other threads:[~2020-12-01 11:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:52 [PATCH] fbdev: Remove udlfb driver Thomas Zimmermann
2020-11-30 14:31 ` Mikulas Patocka
2020-11-30 15:41 ` Daniel Vetter
2020-11-30 18:39 ` Mikulas Patocka
2020-11-30 21:06 ` Daniel Vetter
2020-12-01 11:26 ` Mikulas Patocka [this message]
2020-12-01 8:07 ` Thomas Zimmermann
2020-12-01 11:20 ` Mikulas Patocka
2020-12-02 7:55 ` Thomas Zimmermann
2020-12-02 8:01 ` Thomas Zimmermann
2020-12-02 8:29 ` Pekka Paalanen
2020-12-02 17:52 ` Daniel Vetter
2020-12-01 8:02 ` Thomas Zimmermann
2020-12-01 10:44 ` Mikulas Patocka
2020-12-01 20:09 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.2012010621100.1371@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=bernie@plugable.com \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).