From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9BAC64E7B for ; Mon, 30 Nov 2020 12:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F25D720643 for ; Mon, 30 Nov 2020 12:17:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728295AbgK3MRb (ORCPT ); Mon, 30 Nov 2020 07:17:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:49782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbgK3MRb (ORCPT ); Mon, 30 Nov 2020 07:17:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A3D34AE6D; Mon, 30 Nov 2020 12:16:48 +0000 (UTC) Subject: Re: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan , Andrew Morton References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-16-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: Date: Mon, 30 Nov 2020 13:16:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-16-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4Y7UxgMc6TgXteUKbdi0lV678loDCJ9Ly" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4Y7UxgMc6TgXteUKbdi0lV678loDCJ9Ly Content-Type: multipart/mixed; boundary="QXEs9MxKdZRg0Mhi10RjBI97xuRMPvrUm"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan , Andrew Morton Message-ID: Subject: Re: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-16-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-16-sam@ravnborg.org> --QXEs9MxKdZRg0Mhi10RjBI97xuRMPvrUm Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > Fix W=3D1 warnings by removing unused code >=20 > v2: > - Updated subject (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Bartlomiej Zolnierkiewicz > Cc: Sam Ravnborg > Cc: Andrew Morton > Cc: Evgeny Novikov > Cc: Jani Nikula > Cc: Mike Rapoport > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/neofb.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c > index 09a20d4ab35f..c0f4f402da3f 100644 > --- a/drivers/video/fbdev/neofb.c > +++ b/drivers/video/fbdev/neofb.c > @@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info) > struct neofb_par *par =3D info->par; > int videoRam =3D 896; > int maxClock =3D 65000; > - int CursorMem =3D 1024; > int CursorOff =3D 0x100; > =20 > DBG("neo_init_hw"); > @@ -1895,19 +1894,16 @@ static int neo_init_hw(struct fb_info *info) > case FB_ACCEL_NEOMAGIC_NM2070: > case FB_ACCEL_NEOMAGIC_NM2090: > case FB_ACCEL_NEOMAGIC_NM2093: > - CursorMem =3D 2048; > CursorOff =3D 0x100; > break; > case FB_ACCEL_NEOMAGIC_NM2097: > case FB_ACCEL_NEOMAGIC_NM2160: > - CursorMem =3D 1024; > CursorOff =3D 0x100; > break; > case FB_ACCEL_NEOMAGIC_NM2200: > case FB_ACCEL_NEOMAGIC_NM2230: > case FB_ACCEL_NEOMAGIC_NM2360: > case FB_ACCEL_NEOMAGIC_NM2380: > - CursorMem =3D 1024; > CursorOff =3D 0x1000; > =20 > par->neo2200 =3D (Neo2200 __iomem *) par->mmio_vbase; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --QXEs9MxKdZRg0Mhi10RjBI97xuRMPvrUm-- --4Y7UxgMc6TgXteUKbdi0lV678loDCJ9Ly Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/E4q4FAwAAAAAACgkQlh/E3EQov+CH SBAAopMN3BkNPFw4VASPIZ5g5VSwuH7EpRYKe43piUrNT5IzRdQdltP4f2vuJzBsyNoPE/VmUPYx oqZN1IsalduqcB+4/i/tAV+ysBK1Jrb/BjCRY/x7jIRFLDLHcUVU5VHE5n1D3LClLjWwgkDxJWMJ SusXAzflbY+R/fO4Ji4w//614GRw1jPB6flapbGM33x6LSGeMwGHOkSMnVC0+ajXRmDz0idbhlOE NaatIZmFIBEpHCsWMxSsQAKCD4ZacSC7cVnn1E60PbYiSDIaYK8GqJQ2f4Mw94tn+Yt3uv/G+TXN EOVPvZ4c5N+D95ydtX0iu8Yz3EwmYCvYsCwZTS2XN8zBbH8ZiWJxx2AX/0Jq8EyqgLMZeIgD14Ak sdBOzX0Kqlmh3iTl+E7G0b+VpsL7JfGIcYlHzMZUUHLWv9gM8O1wBC4FJ0EoME6ecz7Zk8clGOI+ BQB+O2CPqSTJbRhF0UhsuTNYLc/JNlZ+zzInbPfQV8j5bGHdyqKDvb+d716nXISFO3fIlun8AY8A /EusZBo4ZUf8yx1l4XSFON9l6k1xD7RfBFs64JQWyTdyU8cFIA8hp6GEekXTPgkiHerWt1ToLB09 6h1wIPtRMbFcNG8WrSltVQnVQrFO/ITTW+M/2ff4oSPIKOn9rpGaaJhwIX8HfDItbJhXy0WOiYo2 7r0= =5w5w -----END PGP SIGNATURE----- --4Y7UxgMc6TgXteUKbdi0lV678loDCJ9Ly--