From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D836C6FD1F for ; Sun, 19 Mar 2023 21:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbjCSVoD (ORCPT ); Sun, 19 Mar 2023 17:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbjCSVoC (ORCPT ); Sun, 19 Mar 2023 17:44:02 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C20940FE; Sun, 19 Mar 2023 14:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679262105; i=deller@gmx.de; bh=/w73ZFCv1Qm1Ts7RFrt74S83t9SlJMyPOGfs6s5w6vA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=tye27jpqsnJEQ5r1aPRWUdOel0H0Qq18wodWOSgRW2UGJMI0OWIKRoZay6CPYhS07 SjX9tFAEh+mFBbeBnx0IPJsoan/zTpEmbLrTqgrZEEnFg6AwH+fbJhCs9PoVJR0D+m OtWpFcvTSIqeJh9ri2123YEQAk0rEueQ4FIBwfAb93CW+Hcggp2qWZmBFnsZEgA6vz hcRtEHaq5HTYQbFhFnn13Thv85Boqf1g1MXexMJG98FW1qWozzIfJKgyOIcT6OpRcL CY96oXEvHOHpeMvVsFeKuNanEugd6kBmYqQkbh3t/FnxOh1lZvYb8jh3sfQRCQTeoh +7ht4ObM92auA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.150.189]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQMyf-1pr1M93om1-00MKnb; Sun, 19 Mar 2023 22:41:45 +0100 Message-ID: Date: Sun, 19 Mar 2023 22:41:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: Yihao Han , Javier Martinez Canillas , Thomas Zimmermann , Wolfram Sang , Alexander Shiyan , Dongliang Mu , Peter Jones , Gaosheng Cui , Timur Tabi , Xuezhi Zhang , Jiasheng Jiang , Ferenc Bakonyi , Sascha Hauer , Shawn Guo , Christophe Leroy , Stephen Kitt , Daniel Thompson , Mark Brown , Rob Herring , Arnd Bergmann , Tony Lindgren , Jiapeng Chong , Yu Zhe , Xu Panda , Zhang Qilong , Hyunwoo Kim , Yang Yingliang , Robert Jarzmik , Ulf Hansson , Wang Qing , Kristoffer Ericson , Jingoo Han , ye xingchen , Geert Uytterhoeven , Hans de Goede , Daniel Vetter , Zeng Heng , Florian Tobias Schandinat , Michal Simek , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team , kernel@pengutronix.de, linux-nvidia@lists.surfsouth.com, linux-omap@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org References: <20230318235428.272091-1-u.kleine-koenig@pengutronix.de> <20230319210808.apsba7oj32kt7ree@pengutronix.de> From: Helge Deller In-Reply-To: <20230319210808.apsba7oj32kt7ree@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xwAGQRhydUJn6LP7AgZcAr5scedxzicgjKoLbjwAcTNGaDnp+/z X/f8IJhruTRzlrsBt0ZC2L5dIbISHZ+hED1MX8JD70H7Hkv7HdoaObXrwmlQj4ZWyWTO2LM 5+qTlW59Ypi/saa8hZ1BbN/Oijdnie0uRdl7imP3UU9GfmjnrDWQB/x5UI1hnXMIoqrIGj3 MynjfG8fllx3mD8aaD/Yw== UI-OutboundReport: notjunk:1;M01:P0:1Tu6xu/NmPA=;+Otc//YaDs9ii4mcEMCpkmMkYfh LG/Sb1kOuUGuYsbm4jQn7qd2NHbEAfU3B6zOh9ubIRUH9yA78KDaRXs1kI4We2Jk1T+y7IWPz 2AzCjvJdZ+AcTcDF7Wj3nPslBCXvWhwZSGB8AmcfABm2T8+2tbC/+tCX8oVzETEhTn/PwKgI5 D4COPEQ/gnN01lBBsj1HgtYjeYeIkXPiY9lzRnGaWbvZ7k2ftn5KcHKl1T868bfezLcVO0155 CgQdF6HgoGdGwYzYCulnFZ3AP0gsTnoJr+PS1JzgYYnT5ekxhm0GqDDSsOXQ0r8ZB+E6cAUfr QXnGiq7pOjai2UnvtctRleqiDr9+DFDSbzLIxenRwdi7IDERMQgtRaV67BhEebPE0M56MFOaP Hc8jw+ModhfNKqVO7oiCuxHewgPw9MdLBbXioEL6HDTEjqoe3+Ix58s7ZKD17/77GcWzmpaSA 0jD3bE7lamumRNWDYjaeV7JZ2GKW7BMajVrt4CGb58XhgPyZ7n6FOpceVmOvfmWQ1/SsVec5+ Qhw62+3ob8WJ5RnCVJwRQY1CHtaQ+V0Hz6Ic2Tzm9CrpczqOQrlYmVWdtlWDvJ2PXXFCjpRBI IWZfp8p5nhMxs2/tQ2Mz8w/XNj60RWMeShvm56h2+QuezyomYzY+XIG7cqpLZYbt5vSWfrQS4 RyiE2ZNYSaLCK3CqhhW9rM4Z0depojewzmE0DrTa2nmBF7r1ZZTZDA17JYjgE/S2pwLtqsioN h32pBS6RSt646pXvTRL7NGTGJWoIgXsiKvSJAA17IrQnwhe+W50fbc670uqGleaD5C3GPHKq6 QUVcMX+fkzK1ckRRVk0jlJ/IPGUZoi26Z962uF2xtsPoboaL0cn82qol0ER0VtWtdVsc3yg1j R3Bx0nWSo4hG9BJ/jZYMODN/jWArr92ba1958yK94+5/QPNvB7krwRpYkoMR0elJjQjqsJ4nD faSnYl5aOUUha83TpbX3y38rP3o= Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 3/19/23 22:08, Uwe Kleine-K=C3=B6nig wrote: > Hello, > > [Dropped Bartlomiej Zolnierkiewicz and Michal Januszewski from Cc, their > email addresses bounced] > > On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote: >> Hello Uwe, >> >> On 3/19/23 00:53, Uwe Kleine-K=C3=B6nig wrote: >>> this series adapts the platform drivers below drivers/video/fbdev to u= se the >>> .remove_new() callback. Compared to the traditional .remove() callback >>> .remove_new() returns no value. This is a good thing because the drive= r core >>> doesn't (and cannot) cope for errors during remove. The only effect of= a >>> non-zero return value in .remove() is that the driver core emits a war= ning. The >>> device is removed anyhow and an early return from .remove() usually yi= elds a >>> resource leak. >>> >>> By changing the remove callback to return void driver authors cannot >>> reasonably assume any more that there is some kind of cleanup later. >>> >>> The first patch simplifies the remove callback of one driver to obviou= sly >>> always return zero. After that all drivers are converted trivially to >>> .remove_new(). >> >> Thanks for that patch series. It's a nice cleanup. >> I've applied it to the fbdev "for-next" git tree for now to get some co= mpile testing. >> I hope that's ok for you. >> >> Regarding the new "remove_new" struct member I'd prefer a better name b= ut don't >> have any idea yet... > > Ideally we won't have to life with it for long. The eventual plan is to > switch back to "remove" once all drivers are converted. So I didn't > think intensively about a better name. Ok. > Did you know that struct i2c_driver has a "temporary" .probe_new() > callback since 2016? No, I didn't knew. Nice :-) Helge