linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/13] drivers/video: W=1 warning fixes
@ 2020-12-06 19:02 Sam Ravnborg
  2020-12-06 19:02 ` [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
                   ` (13 more replies)
  0 siblings, 14 replies; 36+ messages in thread
From: Sam Ravnborg @ 2020-12-06 19:02 UTC (permalink / raw)
  To: linux-fbdev, dri-devel, Lee Jones
  Cc: Alexander Klimov, Andrew Morton, Andrzej Hajda, Arnd Bergmann,
	Bartlomiej Zolnierkiewicz, Colin Ian King, Daniel Vetter,
	Douglas Anderson, Geert Uytterhoeven, Gustavo A R Silva,
	Kuninori Morimoto, linux-arm-kernel, Michael Ellerman,
	Mike Rapoport, Peter Jones, Peter Zijlstra, Qilong Zhang,
	Randy Dunlap, Rich Felker, Sam Ravnborg, Thierry Reding,
	Thomas Winischhofer, Thomas Zimmermann, Tony Prisk

Following the great work of Lee Jones in other subsystems
here is a set of patches that address all remaining W=1
warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so
this is mostly fbdev related fixes.

The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables

Build tested on a set of architectures with various configs.

The patches do not depend on each other and fixes for one driver
are kept in a single patch.

v2:
  - Updated subject of the patches to tell what was fixed (Lee)
  - Fixed build error in one patch (kernel test robot)
  - A few editorials updates to the changelog messages

v3:
  - Applied patches that was acked - thanks Thomas!
  - Updated patches after feedback from Randy and Thomas
  - Added several new patches to cover warnings that triggers
    with other architectures than the one I used for v1 + v2
  - Included one sh specific fix that handle a corner-case,
    let's see what the sh people say to that
  - One fix to previous set of patches to fix an issue
    reported by Coverity (By Colin)

	Sam

Sam Ravnborg (13):
      video: fbdev: hgafb: Fix kernel-doc warnings
      video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify
      video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core
      video: fbdev: uvesafb: Fix set but not used warning
      sh: Fix set but not used warnings with !CONFIG_MMU
      video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
      video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write
      video: fbdev: wmt_ge_rops: Fix function not declared warnings
      video: fbdev: goldfishfb: Fix defined but not used warning
      video: fbdev: gbefb: Fix set but not used warning
      video: fbdev: efifb: Fix set but not used warning for screen_pitch
      video: fbdev: controlfb: Fix set but not used warnings
      video: fbdev: sis: Drop useless call to SiS_GetResInfo()


 arch/sh/include/asm/io.h                          |  2 +-
 drivers/video/fbdev/bw2.c                         |  2 +-
 drivers/video/fbdev/cg3.c                         |  2 +-
 drivers/video/fbdev/cg6.c                         |  2 +-
 drivers/video/fbdev/controlfb.c                   |  4 ++--
 drivers/video/fbdev/core/fb_notify.c              | 10 ++++++++++
 drivers/video/fbdev/core/fbmon.c                  |  2 +-
 drivers/video/fbdev/efifb.c                       |  3 +--
 drivers/video/fbdev/ffb.c                         |  2 +-
 drivers/video/fbdev/gbefb.c                       |  4 +---
 drivers/video/fbdev/goldfishfb.c                  |  2 ++
 drivers/video/fbdev/hgafb.c                       | 10 +++++-----
 drivers/video/fbdev/leo.c                         |  2 +-
 drivers/video/fbdev/mmp/hw/mmp_spi.c              |  2 +-
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c |  4 ++--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c |  4 ++--
 drivers/video/fbdev/p9100.c                       |  2 +-
 drivers/video/fbdev/sis/init.c                    |  1 -
 drivers/video/fbdev/tcx.c                         |  2 +-
 drivers/video/fbdev/uvesafb.c                     |  2 ++
 drivers/video/fbdev/wmt_ge_rops.c                 |  1 +
 21 files changed, 38 insertions(+), 27 deletions(-)



^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2020-12-08 18:03 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-06 19:02 [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
2020-12-06 19:34   ` Randy Dunlap
2020-12-06 19:02 ` [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg
2020-12-06 19:37   ` Randy Dunlap
2020-12-06 20:52     ` Sam Ravnborg
2020-12-06 21:27       ` Randy Dunlap
2020-12-07  8:16     ` Thomas Zimmermann
2020-12-07 16:43       ` Randy Dunlap
2020-12-07 17:12         ` Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg
2020-12-07  8:17   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg
2020-12-07  8:18   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Sam Ravnborg
2020-12-06 21:19   ` kernel test robot
2020-12-06 21:48     ` Sam Ravnborg
2020-12-06 21:49       ` Sam Ravnborg
2020-12-07  8:19   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode Sam Ravnborg
2020-12-07  8:21   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write Sam Ravnborg
2020-12-07 13:48   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings Sam Ravnborg
2020-12-07 13:49   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning Sam Ravnborg
2020-12-07 13:49   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 10/13] video: fbdev: gbefb: Fix set " Sam Ravnborg
2020-12-07 13:50   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch Sam Ravnborg
2020-12-07 13:51   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings Sam Ravnborg
2020-12-07 13:52   ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo() Sam Ravnborg
2020-12-07 13:53   ` Thomas Zimmermann
2020-12-08 18:02 ` [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).