From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01461C83012 for ; Tue, 1 Dec 2020 10:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B53F220770 for ; Tue, 1 Dec 2020 10:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729139AbgLAKHB (ORCPT ); Tue, 1 Dec 2020 05:07:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:44264 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729678AbgLAKHB (ORCPT ); Tue, 1 Dec 2020 05:07:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8AD51ADAA; Tue, 1 Dec 2020 10:06:19 +0000 (UTC) Subject: Re: [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-24-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: Date: Tue, 1 Dec 2020 11:06:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-24-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Iq9PZI8r9vCcI3bZAplE2EAZEouGYt1R" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Iq9PZI8r9vCcI3bZAplE2EAZEouGYt1R Content-Type: multipart/mixed; boundary="LBbpu34wRRGGfp4TDcdp58GW5uCyI4FtV"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan Message-ID: Subject: Re: [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-24-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-24-sam@ravnborg.org> --LBbpu34wRRGGfp4TDcdp58GW5uCyI4FtV Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > Fix a few W=3D1 warnings about unused assignments. > Drop the unused error code. >=20 > v2: > - Subject updated (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg > Cc: Qilong Zhang > Cc: "Alexander A. Klimov" > Cc: Daniel Vetter > Cc: Lee Jones > --- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > index 726c190862d4..e6363a420933 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > @@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config acore; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); I'd rather return the error reported by hdmi_compute_acr() Best regards Thomas > =20 > /* Audio clock regeneration settings */ > acore.n =3D n; > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > index eda29d3032e1..cb63bc0e92ca 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > @@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config core_cfg; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > core_cfg.n =3D n; > core_cfg.cts =3D cts; > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --LBbpu34wRRGGfp4TDcdp58GW5uCyI4FtV-- --9Iq9PZI8r9vCcI3bZAplE2EAZEouGYt1R Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/GFZgFAwAAAAAACgkQlh/E3EQov+CP TxAAnqerj89VsWhx3ZO0QuFg21eiLyPsIqrAChBffFa3mjNRb7HdwiTbBFrNYYr/Z01w/mACAWQG DHGX8XRttG0ovfRqw/EZnKQUtbXYXbZ8nh0m5fmVgSFKyqIcDkMy4hXPYLDiVP0xSln7CIgadalm dY+ISxjTMA4l2D2RkTWZLk1r/Zq2Bq+PyE/zkeGpR/IGykLSv6V9DEr8xg3q+IeaDsSPVtrI8EV4 tLsQR9t02qZsBQ2T00D3NnHSXHMh8qEiKZnpFIRqTowwniho7Yilv6dhLf13+PwLD0rIKc7K128o u16EgRh6VOu681FxPyghLQ2C5qy9d4Dg9Arij/pZsY1XLSDbrYglRnbThi5TDHc//GIgIOEXHmnz Pk3wFqi484et59nMdS1s+OKguNKpphFQcHWzauLfBf5UHhg9DyYDAMYe3coEXx6j/nWfujAHsyAQ g5ANk4QpiRVvFbssnFU/lf21cr2ILarOftHd2k8c9ZJznCw9I3u2shTOTmFo2o/9PB1I78tNP67g 0nDZgQKmHaljSH9VnJbYvXeoEbDwsqKkXeBq1Y67W1ZAkJkk3fhvLO5MuIpH+jgBpmIeNSONSPbj iNV47/5Lp0sfoGP3Ug0u6AW3n2ES6uocXSi74rOVsFO5wnawjZkfokplMFXgLyi7MQcY3/Id2zgm 2jU= =MIFN -----END PGP SIGNATURE----- --9Iq9PZI8r9vCcI3bZAplE2EAZEouGYt1R--