From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D592C64E7A for ; Tue, 1 Dec 2020 09:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEDB1204FD for ; Tue, 1 Dec 2020 09:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725912AbgLAJ64 (ORCPT ); Tue, 1 Dec 2020 04:58:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:36582 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbgLAJ6z (ORCPT ); Tue, 1 Dec 2020 04:58:55 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F6E3AC65; Tue, 1 Dec 2020 09:58:14 +0000 (UTC) Subject: Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay To: Sam Ravnborg Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Vaibhav Gupta , Tetsuo Handa , Laurent Pinchart , Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Peter Rosin , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peilin Ye , Mike Rapoport References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-9-sam@ravnborg.org> <2b2809ab-a9ab-cf6d-248d-828ca584bdee@suse.de> <20201130190132.GB1502362@ravnborg.org> From: Thomas Zimmermann Message-ID: Date: Tue, 1 Dec 2020 10:58:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201130190132.GB1502362@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NRbffqMogAfFUElMvRsOiHmPs9btjWeEX" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NRbffqMogAfFUElMvRsOiHmPs9btjWeEX Content-Type: multipart/mixed; boundary="yNgj5c9ZvHxjjDrhmXedYdfhnGovl1hBl"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Vaibhav Gupta , Tetsuo Handa , Laurent Pinchart , Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Peter Rosin , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peilin Ye , Mike Rapoport Message-ID: Subject: Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-9-sam@ravnborg.org> <2b2809ab-a9ab-cf6d-248d-828ca584bdee@suse.de> <20201130190132.GB1502362@ravnborg.org> In-Reply-To: <20201130190132.GB1502362@ravnborg.org> --yNgj5c9ZvHxjjDrhmXedYdfhnGovl1hBl Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 30.11.20 um 20:01 schrieb Sam Ravnborg: > Hi Thomas. >=20 > On Mon, Nov 30, 2020 at 10:13:05AM +0100, Thomas Zimmermann wrote: >> >> >> Am 28.11.20 um 23:40 schrieb Sam Ravnborg: >>> Fix W=3D1 warning by commenting unused SiS_TVDelay* variables. >>> >>> The SiS_TVDelay* variables seem to contain some magic numbers >>> so looks like data worth keeping around but not as code we build. >> >> I would remove it. sisfb is broken beyond repair and no one's going to= try >> to use it anyway. In any case >> >> Acked-by: Thomas Zimemrmann >=20 > Thanks for your patience pointing out all my spelling and grammar error= s. > I once had codespell set up to catch some of this, will need to do so > again. >=20 > Ironically I copied the above "Acked-by:" line to most of the commits > and just noticed it had a spelling error :-) Perfect! :D >=20 > I have applied everything that you acked and will push when > I have fixed the above and verified I did not break anything. > Will post a v3 with the remaining patches later. >=20 > Sam >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --yNgj5c9ZvHxjjDrhmXedYdfhnGovl1hBl-- --NRbffqMogAfFUElMvRsOiHmPs9btjWeEX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/GE7EFAwAAAAAACgkQlh/E3EQov+CR 1RAA0V5kqLWnj1ANMrgxvARswJ5AYSx9jeJOPzR3UMQhaA+6wJ1/SYfStHdN4JstreNKFZpf0zUe WRtjdJYebkaMZMQzEs0qyXDmZGiHCClvCLDcrRmfuEweAWarTGNRu6gpFK9n0HDq3KK4qIgvqHdl Tcl60sTCiHnxODp253q/DN7ZWndOiQSJ9VL5zu+YvA2DFXVZ0ad2p0ZQpdu9FHQU6yaszhkSRkMS Jx16Gq82JpRtmadmzA9Gq2j/q2CY/sxeAeFNLgPmJhTX/xxxFmZlfQs3DQ/N8/G1EsZSrxKXgNRd g2O3EmhoLLwU9VlJ9WJR12yaNZR9/gGaKPZnxHxkAylJUxvSkqmmfk+/fB5p3F31IlBN/d4iMLhV vl+HjqHFs2svim53diCUoqJ9cZdi42o0t4Tt1AiTC7+9H8AHhhWFo8k2Q369XF6+dCq9AI182+bk LqtwOXckyyIddJeS106sgoJ6S9KFRZ1qtMRVxLEAj/Jh6mCKUcJAy68OMWeWY8zv0WUQYK6ejstq 10ZOSwh19SUalA+R12fuNZVpUP7hsVgjrdtBOAl8JKZ80QdZyFDSx66X911mPGHvpYCBiGVE0B0Q 5QOjhj4aNWWPuP5zW6GA9l9xLr0aLZnXAxceemK0c4EzQ36SZ3Al0T+H5qvFRe6z3VIcj5KMxWJ1 pfs= =oZNT -----END PGP SIGNATURE----- --NRbffqMogAfFUElMvRsOiHmPs9btjWeEX--