From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C499C4BA0B for ; Wed, 26 Feb 2020 04:46:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) id EC1BB24650; Wed, 26 Feb 2020 04:46:01 +0000 (UTC) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2E0A21927 for ; Wed, 26 Feb 2020 04:46:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ofvWS/in" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2E0A21927 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=acourbot@chromium.org Received: by mail-ot1-f66.google.com with SMTP id h9so1743385otj.11 for ; Tue, 25 Feb 2020 20:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EKUyDP4lZW18OTJVqKNfcbTr/pNluBP+Ac8mA7k4evM=; b=ofvWS/inAusVCo3l1y8QovhX4A7p7BrHR3o/38cH5h/oY+oPPGklAZwzipfIf14QU6 potN5ZirnfbpuqlD3FbwCDt68S2VNziAe29j031oaTGqS5jme9cfqbcq9aS2Ev3tHZ+Y 4l+XyIFM0jvqUyCko5LHBk01vlk6v3SmOhxMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EKUyDP4lZW18OTJVqKNfcbTr/pNluBP+Ac8mA7k4evM=; b=bg+9+ACQYoynjVh/aqK9GLamTi/DtI0EZH0QzspJw9/CZSO+9P4iOrMCrad2qTrtB1 d37MxGWrW182WBfU+HvhWGtEhalEkElwdbqOez02dwxHSnTXAQ/gqqMhHIjoQBUF29mg t8QbkrJg1DCDi6wPsFB97mSjH1IRGhfqsURlBYHLsivUZAFzKWgVZfg37x4IuoKUqp+J xfjx9bGjQP+6kiVdnPVdgSvycUOK71kYZR+8+wJc4mCCvxfLEDBShAASGXOLWkWBgt0k 8cPoeOKxE1F6wEKKf01fCmAj8Jh1KU8qToOn/LKiJxK9OLtJ2cOiT7pXusuroSYyGqQr 0+3Q== X-Gm-Message-State: APjAAAULAqcHUT67tG/ITgsYnkDQdEp61aRgqWnSbgVUU8eZv9Q509Qo 8CFXlnvjQgH9R7QjxOM9z1G9bVSejYWprQ== X-Google-Smtp-Source: APXvYqzDVFDrDgcjTmEByv13Ov8Y5MB0H4Gi1WcAOtZox48lr5epA7E9SlshNLsfmRFMOJfYiDCY7w== X-Received: by 2002:a9d:68d9:: with SMTP id i25mr1557370oto.135.1582692360013; Tue, 25 Feb 2020 20:46:00 -0800 (PST) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com. [209.85.210.41]) by smtp.gmail.com with ESMTPSA id t20sm356645oij.19.2020.02.25.20.45.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2020 20:45:59 -0800 (PST) Received: by mail-ot1-f41.google.com with SMTP id j20so1797906otq.3 for ; Tue, 25 Feb 2020 20:45:58 -0800 (PST) X-Received: by 2002:a05:6830:13da:: with SMTP id e26mr1449424otq.97.1582692357955; Tue, 25 Feb 2020 20:45:57 -0800 (PST) MIME-Version: 1.0 References: <20200226033646.20949-1-gtk_ruiwang@mediatek.com> <20200226033646.20949-2-gtk_ruiwang@mediatek.com> <1582690790.6276.19.camel@mhfsdcap03> In-Reply-To: <1582690790.6276.19.camel@mhfsdcap03> From: Alexandre Courbot Date: Wed, 26 Feb 2020 13:45:46 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mediatek: move MT8173 VPU FW to subfolder To: gtk_ruiwang List-Id: Cc: linux-firmware@kernel.org, Linux Media Mailing List , LKML , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , srv_heupstream@mediatek.com, Tomasz Figa , PoChun.Lin@mediatek.com, Longfei Wang , Yunfei Dong , Maoguang Meng Content-Type: text/plain; charset="UTF-8" Message-ID: <20200226044546.3PHTZSCk9vUx1gAp-x1q3zULSPS3P0x1v0hMwQBPJLc@z> On Wed, Feb 26, 2020 at 1:20 PM gtk_ruiwang wrote: > > Dear Alex, > > Do you mean to create two symbolic link? > > lrwxrwxrwx 1 gtk_ruiwang gtk_ruiwang 25 Feb 26 11:52 vpu_d.bin -> > mediatek/mt8173/vpu_d.bin > lrwxrwxrwx 1 gtk_ruiwang gtk_ruiwang 25 Feb 26 11:52 vpu_p.bin -> > mediatek/mt8173/vpu_p.bin Yes, otherwise older kernels will become unable to use the firmware. I don't know whether these are supposed to stay forever or whether we can remove them after a while... presumably the former. Also the WHENCE file should probably be updated to list the new files. > > we create them at the linux-firmware root folder. > > Thanks > Best Regards > > On Wed, 2020-02-26 at 12:41 +0900, Alexandre Courbot wrote: > > On Wed, Feb 26, 2020 at 12:38 PM wrote: > > > > > > From: gtk_ruiwang > > > > > > Currently vpu_d.bin and vpu_p.bin are at the root of > > > linux-firmware git tree, it's not appropriate so we move > > > them to subfolder mediatek/mt8173 > > > > > > Release Version: 1.1.4 > > > > > > Signed-off-by: Rui Wang > > > --- > > > vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin > > > vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin > > > 2 files changed, 0 insertions(+), 0 deletions(-) > > > rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%) > > > rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%) > > > > This is nice as it removes some stuff from the root, but for > > compatibility with older kernels that don't know about the new path > > shouldn't we at least temporarily create a symbolic link between the > > old location and the new one? >