Linux-Firmware Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] Bluetooth: print fw build version in power-on boot
@ 2020-03-13  5:16 Amit K Bag
  2020-03-13  5:16 ` Amit K Bag
  0 siblings, 1 reply; 6+ messages in thread
From: Amit K Bag @ 2020-03-13  5:16 UTC (permalink / raw)
  To: linux-firmware
  Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan,
	Sukumar Ghorai, Amit K Bag

From: Sukumar Ghorai <sukumar.ghorai@intel.com>

To determine the build version of Bluetooth firmware to ensure reported
issue related to a particular release. This is very helpful for every fw
downloaded to BT controller and issue reported from field test.

Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
Signed-off-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
---
 drivers/bluetooth/btusb.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f5924f3e8b8d..c1e8b8d4931e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1930,7 +1930,14 @@ static int btusb_setup_intel(struct hci_dev *hdev)
 	if (err)
 		return err;
 
-	bt_dev_info(hdev, "Intel firmware patch completed and activated");
+	/* Need build number for downloaded fw patches in
+	 * every power-on boot
+	 */
+       err = btintel_read_version(hdev, &ver);
+       if (err)
+               return err;
+       bt_dev_info(hdev, "Intel BT fw patch 0x%02x completed & activated",
+		   hdev->name, ver.fw_patch_num);
 
 	goto complete;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3] Bluetooth: print fw build version in power-on boot
  2020-03-13  5:16 [PATCH v3] Bluetooth: print fw build version in power-on boot Amit K Bag
@ 2020-03-13  5:16 ` Amit K Bag
  0 siblings, 0 replies; 6+ messages in thread
From: Amit K Bag @ 2020-03-13  5:16 UTC (permalink / raw)
  To: linux-firmware
  Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan,
	Sukumar Ghorai, Amit K Bag

From: Sukumar Ghorai <sukumar.ghorai@intel.com>

To determine the build version of Bluetooth firmware to ensure reported
issue related to a particular release. This is very helpful for every fw
downloaded to BT controller and issue reported from field test.

Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
Signed-off-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
---
 drivers/bluetooth/btusb.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f5924f3e8b8d..c1e8b8d4931e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1930,7 +1930,14 @@ static int btusb_setup_intel(struct hci_dev *hdev)
 	if (err)
 		return err;
 
-	bt_dev_info(hdev, "Intel firmware patch completed and activated");
+	/* Need build number for downloaded fw patches in
+	 * every power-on boot
+	 */
+       err = btintel_read_version(hdev, &ver);
+       if (err)
+               return err;
+       bt_dev_info(hdev, "Intel BT fw patch 0x%02x completed & activated",
+		   hdev->name, ver.fw_patch_num);
 
 	goto complete;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Bluetooth: print fw build version in power-on boot
  2020-03-13  5:19 Amit K Bag
  2020-03-13  5:19 ` Amit K Bag
@ 2020-03-13 18:50 ` Marcel Holtmann
  2020-03-13 18:50   ` Marcel Holtmann
  1 sibling, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2020-03-13 18:50 UTC (permalink / raw)
  To: Amit K Bag
  Cc: linux-firmware, linux-bluetooth, ravishankar.srivatsa,
	chethan.tumkur.narayan, Sukumar Ghorai

Hi Amit,

> To determine the build version of Bluetooth firmware to ensure reported
> issue related to a particular release. This is very helpful for every fw
> downloaded to BT controller and issue reported from field test.
> 
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> Signed-off-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
> ---
> drivers/bluetooth/btusb.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)

I have two v3 versions in my inbox. Please send me a clean v4 that is ready to be applied so that I don’t have to second guess.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Bluetooth: print fw build version in power-on boot
  2020-03-13 18:50 ` Marcel Holtmann
@ 2020-03-13 18:50   ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2020-03-13 18:50 UTC (permalink / raw)
  To: Amit K Bag
  Cc: linux-firmware, linux-bluetooth, ravishankar.srivatsa,
	chethan.tumkur.narayan, Sukumar Ghorai

Hi Amit,

> To determine the build version of Bluetooth firmware to ensure reported
> issue related to a particular release. This is very helpful for every fw
> downloaded to BT controller and issue reported from field test.
> 
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> Signed-off-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
> ---
> drivers/bluetooth/btusb.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)

I have two v3 versions in my inbox. Please send me a clean v4 that is ready to be applied so that I don’t have to second guess.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3] Bluetooth: print fw build version in power-on boot
@ 2020-03-13  5:19 Amit K Bag
  2020-03-13  5:19 ` Amit K Bag
  2020-03-13 18:50 ` Marcel Holtmann
  0 siblings, 2 replies; 6+ messages in thread
From: Amit K Bag @ 2020-03-13  5:19 UTC (permalink / raw)
  To: linux-firmware
  Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan,
	Sukumar Ghorai, Amit K Bag

From: Sukumar Ghorai <sukumar.ghorai@intel.com>

To determine the build version of Bluetooth firmware to ensure reported
issue related to a particular release. This is very helpful for every fw
downloaded to BT controller and issue reported from field test.

Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
Signed-off-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
---
 drivers/bluetooth/btusb.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f5924f3e8b8d..db6211f34300 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1930,7 +1930,14 @@ static int btusb_setup_intel(struct hci_dev *hdev)
 	if (err)
 		return err;
 
-	bt_dev_info(hdev, "Intel firmware patch completed and activated");
+	/* Need build number for downloaded fw patches in
+	 * every power-on boot
+	 */
+       err = btintel_read_version(hdev, &ver);
+       if (err)
+               return err;
+       bt_dev_info(hdev, "Intel BT fw patch 0x%02x completed & activated",
+		   ver.fw_patch_num);
 
 	goto complete;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3] Bluetooth: print fw build version in power-on boot
  2020-03-13  5:19 Amit K Bag
@ 2020-03-13  5:19 ` Amit K Bag
  2020-03-13 18:50 ` Marcel Holtmann
  1 sibling, 0 replies; 6+ messages in thread
From: Amit K Bag @ 2020-03-13  5:19 UTC (permalink / raw)
  To: linux-firmware
  Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan,
	Sukumar Ghorai, Amit K Bag

From: Sukumar Ghorai <sukumar.ghorai@intel.com>

To determine the build version of Bluetooth firmware to ensure reported
issue related to a particular release. This is very helpful for every fw
downloaded to BT controller and issue reported from field test.

Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
Signed-off-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
---
 drivers/bluetooth/btusb.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f5924f3e8b8d..db6211f34300 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1930,7 +1930,14 @@ static int btusb_setup_intel(struct hci_dev *hdev)
 	if (err)
 		return err;
 
-	bt_dev_info(hdev, "Intel firmware patch completed and activated");
+	/* Need build number for downloaded fw patches in
+	 * every power-on boot
+	 */
+       err = btintel_read_version(hdev, &ver);
+       if (err)
+               return err;
+       bt_dev_info(hdev, "Intel BT fw patch 0x%02x completed & activated",
+		   ver.fw_patch_num);
 
 	goto complete;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13  5:16 [PATCH v3] Bluetooth: print fw build version in power-on boot Amit K Bag
2020-03-13  5:16 ` Amit K Bag
2020-03-13  5:19 Amit K Bag
2020-03-13  5:19 ` Amit K Bag
2020-03-13 18:50 ` Marcel Holtmann
2020-03-13 18:50   ` Marcel Holtmann

Linux-Firmware Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \
		linux-firmware@kernel.org
	public-inbox-index linux-firmware

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git