Linux-Firmware Archive on lore.kernel.org
 help / color / Atom feed
From: Nikhil Devshatwar <nikhil.nd@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	<linux-firmware@kernel.org>, <linux-media@vger.kernel.org>,
	Dan Murphy <dmurphy@ti.com>, Benoit Parrot <bparrot@ti.com>,
	Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH] vpdma: Move firmware to the toplevel
Date: Wed, 28 Oct 2020 22:49:24 +0530
Message-ID: <20201028171924.dk2swpi2uzpgz5az@NiksLab> (raw)
In-Reply-To: <868ff235-20c7-b0c0-df08-3d4582adb544@ti.com>

On 09:41-20201028, Tomi Valkeinen wrote:
> On 26/10/2020 23:08, Laurent Pinchart wrote:
> > Hi Nikhil,
> > 
> > Thank you for the patch.
> > 
> > On Tue, Oct 27, 2020 at 01:39:22AM +0530, Nikhil Devshatwar wrote:
> >> Move the vpdma firmware to the toplevel directory so
> >> that the existing drivers can use it with the same path.
> >>
> >> Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
> >> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> >> ---
> >>  WHENCE                                         |   2 +-
> >>  ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin
> > 
> > I think Tomi meant moving the file to ti/ instead of ti-connectivity/. I
> > will let him comment on this.
> 
> I don't really have a strong opinion here, as I don't know if there are some rules or guidelines
> about file/dir naming in linux-firmware.
> 
> But my argument is:
> 
> The fw should either be at the root dir, where the linux driver is already looking for it, OR, if we
> do move it somewhere, move it to a "right" place. Afaics "ti-connectivity" is totally wrong place,
> as vpdma has nothing to do with connectivity.
> 
> The root dir is a bit bad as "vpdma-1b8.bin" doesn't have TI or such in its name, so even if name

With this, I am more inclined to put it in ti/ directory.

> conflict with some other fw feels quite unlikely, the name is still rather vague. And moving is a
> bit bad as then the current driver won't find the fw...

Since the current driver is not getting any firmware anyways, it should
be fine to move it and update the driver accordingly.
I will send v2 with the firmware moved to ti/

> 
>  Tomi
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 20:09 Nikhil Devshatwar
2020-10-26 21:08 ` Laurent Pinchart
2020-10-28  7:41   ` Tomi Valkeinen
2020-10-28 17:19     ` Nikhil Devshatwar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028171924.dk2swpi2uzpgz5az@NiksLab \
    --to=nikhil.nd@ti.com \
    --cc=bparrot@ti.com \
    --cc=dmurphy@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-firmware@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Firmware Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \
		linux-firmware@kernel.org
	public-inbox-index linux-firmware

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git